Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue generator #411

Merged
merged 21 commits into from
Dec 14, 2020
Merged

Queue generator #411

merged 21 commits into from
Dec 14, 2020

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Dec 5, 2020 •
edited
Loading

Description

Added code generator for message queues. This PR

  • adds generation action for message queues "Magento 2 Message Queue"
  • adds generators for all four different files of message queues
    • communication.xml
    • queue_consumer.xml
    • queue_publisher.xml
    • queue_topology.xml
  • adds tests for all four generators
  • adds new validators for queue names and exchange names

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@drpayyne
Copy link
Contributor Author

drpayyne commented Dec 5, 2020

Hello reviewer, the failing tests are occuring on the base 3.0.0-develop branch itself. Could you please check on that?
image

@coderimus coderimus self-assigned this Dec 11, 2020
@coderimus coderimus self-requested a review December 11, 2020 13:35
@VitaliyBoyko VitaliyBoyko changed the base branch from 3.0.0-develop to 3.1.0-develop December 11, 2020 17:15
@coderimus coderimus merged commit 2aa1baf into magento:3.1.0-develop Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderimus coderimus coderimus approved these changes

Assignees

@coderimus coderimus

Labels
Award: category of expertise Award: complex Award: special achievement Award: test coverage Partner: EY partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drpayyne @coderimus @magento-engcom-team