Skip to content

#286 Fixed StringIndexOutOfBoundsException on PluginInspection #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2020
Merged

#286 Fixed StringIndexOutOfBoundsException on PluginInspection #416

merged 1 commit into from
Dec 13, 2020

Conversation

VitaliyBoyko
Copy link
Contributor

Description (*)
To reproduce the issue remove the original method name part from the plugin method name e.g
beforeExecute -> before

Fixed Issues (if relevant)

-->

  1. Fixes phpStorm exception - java.lang.StringIndexOutOfBoundsException: String index out of range: 0 #286

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 self-requested a review December 11, 2020 18:58
eduard13
eduard13 approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix 👍

@eduard13 eduard13 added the Easy label Dec 11, 2020
@coderimus coderimus merged commit 1fca5ce into 3.0.1-develop Dec 13, 2020
@VitaliyBoyko VitaliyBoyko deleted the 286-StringIndexOutOfBoundsException branch December 13, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderimus coderimus coderimus approved these changes

@eduard13 eduard13 eduard13 approved these changes

Assignees

@coderimus coderimus

@eduard13 eduard13

Labels
Easy Partner: Atwix partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VitaliyBoyko @coderimus @eduard13 @magento-engcom-team