Skip to content

Fixed plugin generation for complex non primitive types #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bohdan-harniuk
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk commented Jun 23, 2021

Description (*)
There was detected an issue with the generation of plugins for methods where specified non-primitive complex type as a parameter or as a return type. For example, generation will fail if specify type like that:

class SomeClass {
    public function method(?SomeType = null): ?SomeReturnType
    {  
    }
}

And the result was as:
Screenshot 2021-06-23 at 18 21 44

The result of the fix:
Screenshot 2021-06-24 at 00 18 29
Screenshot 2021-06-24 at 00 18 40

In addition to the correction was also refactored code to be compatible with the last code style rules.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants