ENGCOM-5346: Added filter nfinset in product search #528

magento · Jun 24, 2019 · 068c1ce · 068c1ce
2 parents dc74c48 + 0aebe29
commit 068c1ce
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 31 deletions.
diff --git a/app/code/Magento/GraphQl/etc/schema.graphqls b/app/code/Magento/GraphQl/etc/schema.graphqls
@@ -9,7 +9,7 @@ type Mutation {
 
 input FilterTypeInput @doc(description: "FilterTypeInput specifies which action will be performed in a query ") {
     eq: String @doc(description: "Equals")
-    finset: [String] @doc(description: "Find in set. The value can contain a set of comma-separated values")
+    finset: [String] @deprecated (reason: "The finset filter is deprecated. Magento doesn't recomend to store comma separated values, therefore finset filter is redundant.")
     from: String @doc(description: "From. Must be used with 'to'")
     gt: String @doc(description: "Greater than")
     gteq: String @doc(description: "Greater than or equal to")

diff --git a/dev/tests/integration/testsuite/Magento/Framework/GraphQl/_files/schemaA.graphqls b/dev/tests/integration/testsuite/Magento/Framework/GraphQl/_files/schemaA.graphqls
@@ -8,7 +8,6 @@ type Mutation {
 
 input FilterTypeInput @doc(description:"Comment for FilterTypeInput") {
     eq: String @doc(description:"Equal")
-    finset: [String]
     from: String
     gt: String
     gteq: String

diff --git a/dev/tests/integration/testsuite/Magento/Framework/GraphQl/_files/schemaC.graphqls b/dev/tests/integration/testsuite/Magento/Framework/GraphQl/_files/schemaC.graphqls
@@ -19,7 +19,6 @@ type Attribute @doc(description: "Attribute contains the attribute_type of the s
 }
 input FilterTypeInput @doc(description:"Comment for FilterTypeInput") {
     eq: String @doc(description:"Equal")
-    finset: [String]
     from: String
     gt: String
     gteq: String

diff --git a/...ntegration/testsuite/Magento/Framework/GraphQl/_files/schema_response_sdl_description.php b/...ntegration/testsuite/Magento/Framework/GraphQl/_files/schema_response_sdl_description.php
@@ -505,20 +505,6 @@
                 ],
                 'defaultValue' =>  null
             ],
-            [
-                'name' =>  'finset',
-                'description' =>  '',
-                'type' =>  [
-                    'kind' =>  'LIST',
-                    'name' =>  null,
-                    'ofType' =>  [
-                        'kind' =>  'SCALAR',
-                        'name' =>  'String',
-                        'ofType' =>  null
-                    ]
-                ],
-                'defaultValue' =>  null
-            ],
             [
                 'name' =>  'from',
                 'description' =>  '',

diff --git a/...ts/integration/testsuite/Magento/Framework/GraphQl/_files/schema_with_description_sdl.php b/...ts/integration/testsuite/Magento/Framework/GraphQl/_files/schema_with_description_sdl.php
@@ -505,20 +505,6 @@
                 ],
                 'defaultValue' =>  null
             ],
-            [
-                'name' =>  'finset',
-                'description' =>  '',
-                'type' =>  [
-                    'kind' =>  'LIST',
-                    'name' =>  null,
-                    'ofType' =>  [
-                        'kind' =>  'SCALAR',
-                        'name' =>  'String',
-                        'ofType' =>  null
-                    ]
-                ],
-                'defaultValue' =>  null
-            ],
             [
                 'name' =>  'from',
                 'description' =>  '',