Reformat the method checkCredentials method for a single return

magento · Jul 26, 2017 · 097fe08 · 097fe08
1 parent acc5353
commit 097fe08
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/setup/src/Magento/Setup/Model/PackagesAuth.php b/setup/src/Magento/Setup/Model/PackagesAuth.php
@@ -99,6 +99,7 @@ public function getCredentialBaseUrl()
      */
     public function checkCredentials($token, $secretKey)
     {
+        $response = ['success' => true];
         $serviceUrl = $this->getPackagesJsonUrl();
         $this->curlClient->setCredentials($token, $secretKey);
         try {
@@ -107,13 +108,13 @@ public function checkCredentials($token, $secretKey)
                 $packagesInfo = $this->curlClient->getBody();
                 $directory = $this->filesystem->getDirectoryWrite(DirectoryList::COMPOSER_HOME);
                 $directory->writeFile(self::PATH_TO_PACKAGES_FILE, $packagesInfo);
-                return $this->serializer->serialize(['success' => true]);
             } else {
-                return $this->serializer->serialize(['success' => false, 'message' => 'Bad credentials']);
+                $response = ['success' => false, 'message' => 'Bad credentials'];
             }
         } catch (\Exception $e) {
-            return $this->serializer->serialize(['success' => false, 'message' => $e->getMessage()]);
+            $response = ['success' => false, 'message' => $e->getMessage()];
         }
+        return $this->serializer->serialize($response);
     }
 
     /**