🔃 [EngCom] Public Pull Requests - 2.2-develop

Accepted Public Pull Requests:
 - #14440: Removed extra backslash from comment block (by @yogeshks)
 - #14403: test command inside if/then clause broke before install script (by @edie-pasek)
 - #14309: Disable "Back" button on the first step of the setup (by @ArjenMiedema)
 - #14350: precision for price overriding by js (by @cdiacon)


Fixed GitHub Issues:
 - #14307: Possible to press the "Previous" button while in the first step of the installation (reported by @ArjenMiedema) has been fixed in #14309 by @ArjenMiedema in 2.2-develop branch
   Related commits:
     1. 9668ae7
     2. 1bf7685

 - #14249: Priduct page price is using the hardcoded digits in js (reported by @cdiacon) has been fixed in #14350 by @cdiacon in 2.2-develop branch
   Related commits:
     1. 9ea2ccf

app/code/Magento/Catalog/view/base/web/js/price-utils.js

@@ -79,7 +79,7 @@ define([
         am = Number(Math.round(Math.abs(amount - i) + 'e+' + precision) + ('e-' + precision));
         r = (j ? i.substr(0, j) + groupSymbol : '') +
             i.substr(j).replace(re, '$1' + groupSymbol) +
-            (precision ? decimalSymbol + am.toFixed(2).replace(/-/, 0).slice(2) : '');
+            (precision ? decimalSymbol + am.toFixed(precision).replace(/-/, 0).slice(2) : '');
 
         return pattern.replace('%s', r).replace(/^\s\s*/, '').replace(/\s\s*$/, '');
     }

app/code/Magento/InstantPurchase/CustomerData/InstantPurchase.php

@@ -30,7 +30,7 @@ class InstantPurchase implements SectionSourceInterface
     private $customerSession;
 
     /**
-     * @var StoreManagerInterface\
+     * @var StoreManagerInterface
      */
     private $storeManager;
 

dev/travis/before_install.sh

@@ -21,7 +21,7 @@ phpenv rehash;
 test -n "$GITHUB_TOKEN" && composer config github-oauth.github.com "$GITHUB_TOKEN" || true
 
 # Node.js setup via NVM
-if [ test $TEST_SUITE == "js" ]; then
+if [ $TEST_SUITE == "js" ]; then
     curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.1/install.sh | bash
     export NVM_DIR="$HOME/.nvm"
     [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" # This loads nvm

setup/pub/magento/setup/main.js

@@ -93,10 +93,6 @@ main.controller('navigationController',
             return str.indexOf(suffix, str.length - suffix.length) !== -1;
         };
 
-        $scope.goToStart = function() {
-            $scope.goToAction($state.current.type);
-        };
-
         $scope.goToBackup = function() {
             $state.go('root.create-backup-uninstall');
         };

setup/view/magento/setup/readiness-check.phtml

@@ -18,7 +18,7 @@
             <button
                 type="button"
                 class="btn"
-                ng-click="goToStart()"
+                disabled="disabled"
                 >Back</button>
         </div>
         <div class="btn-wrap btn-wrap-try-again"