Merge pull request #1358 from magento-south/MAGETWO-67363

MAGETWO-67363: Setup fixture priority can be duplicated
magento · Jul 25, 2017 · 14e7a37 · 14e7a37
2 parents 5186237 + 981da28
commit 14e7a37
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/setup/src/Magento/Setup/Fixtures/ConfigsApplyFixture.php b/setup/src/Magento/Setup/Fixtures/ConfigsApplyFixture.php
@@ -14,7 +14,7 @@ class ConfigsApplyFixture extends Fixture
     /**
      * @var int
      */
-    protected $priority = 150;
+    protected $priority = 0;
 
     /**
      * {@inheritdoc}

diff --git a/setup/src/Magento/Setup/Fixtures/FixtureModel.php b/setup/src/Magento/Setup/Fixtures/FixtureModel.php
@@ -109,6 +109,11 @@ public function loadFixtures()
                     'fixtureModel' => $this,
                 ]
             );
+            if (isset($this->fixtures[$fixture->getPriority()])) {
+                throw new \InvalidArgumentException(
+                    sprintf('Duplicate priority %d in fixture %s', $fixture->getPriority(), $type)
+                );
+            }
             $this->fixtures[$fixture->getPriority()] = $fixture;
         }