Skip to content

Commit

Permalink
Fix multiple deletion
Browse files Browse the repository at this point in the history
# Case
Use command
```
$ magento module:uninstall Prefix_Module1 Prefix_Module2
```
# Problem
Deletion scripts do not work
  • Loading branch information
Evgeniy Kalashnikov authored Apr 28, 2017
1 parent 15d3681 commit 1650652
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup/src/Magento/Setup/Model/UninstallCollector.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function collectUninstall($filterModules = [])
$setup = $this->dataSetupFactory->create();
$result = $setup->getConnection()->select()->from($setup->getTable('setup_module'), ['module']);
if (isset($filterModules) && sizeof($filterModules) > 0) {
$result->where('module in( ? )', implode(',', $filterModules));
$result->where('module in( ? )', $filterModules);
}
// go through modules
foreach ($setup->getConnection()->fetchAll($result) as $row) {
Expand Down

1 comment on commit 1650652

@edakhmetgareev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

браво Евгений, браво 👏

Please sign in to comment.