improve params string creation according to @orlangur suggestion

magento · Jul 8, 2018 · 3ec7e6d · 3ec7e6d
1 parent 270640f
commit 3ec7e6d
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/app/code/Magento/Backend/Block/Widget/Form/Element/Dependence.php b/app/code/Magento/Backend/Block/Widget/Form/Element/Dependence.php
@@ -121,14 +121,15 @@ protected function _toHtml()
             return '';
         }
 
-        $dependsJson = $this->_getDependsJson();
-        $configOptions = $this->_configOptions ? $this->_jsonEncoder->encode($this->_configOptions) : null;
-        $configOptionsStr = $configOptions ? ', ' . $configOptions : '';
-        $paramsStr = $dependsJson . $configOptionsStr;
+        $params = $this->_getDependsJson();
+
+        if ($this->_configOptions) {
+            $params .= ', ' .  $this->_jsonEncoder->encode($this->_configOptions);
+        }
 
         return "<script>
-    require(['mage/adminhtml/form'], function(){
-    new FormElementDependenceController({$paramsStr});
+require(['mage/adminhtml/form'], function(){
+    new FormElementDependenceController({$params});
 });
 </script>";
     }