MC-31985: [Functional Test Failed]: Functional Tests were failing bec…

…ause of changes to Modal - reverted #25349 - reverted magento/partners-magento2b2b#49
magento · Feb 27, 2020 · 6167b0c · 6167b0c
1 parent 3fd50f2
commit 6167b0c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/app/code/Magento/Ui/view/base/web/js/modal/modal.js b/app/code/Magento/Ui/view/base/web/js/modal/modal.js
@@ -308,7 +308,7 @@ define([
          * Close modal.
          * * @return {Element} - current element.
          */
-        closeModal: function (event, result) {//eslint-disable-line no-unused-vars
+        closeModal: function () {
             var that = this;
 
             this._removeKeyListener();

diff --git a/app/code/Magento/Ui/view/base/web/js/modal/prompt.js b/app/code/Magento/Ui/view/base/web/js/modal/prompt.js
@@ -51,8 +51,8 @@ define([
                 /**
                  * Click handler.
                  */
-                click: function (event) {
-                    this.closeModal(event);
+                click: function () {
+                    this.closeModal();
                 }
             }, {
                 text: $.mage.__('OK'),
@@ -61,8 +61,8 @@ define([
                 /**
                  * Click handler.
                  */
-                click: function (event) {
-                    this.closeModal(event, true);
+                click: function () {
+                    this.closeModal(true);
                 }
             }]
         },
@@ -75,7 +75,7 @@ define([
             this.options.validation = this.options.validation && this.options.validationRules.length;
             this._super();
             this.modal.find(this.options.modalContent).append(this.getFormTemplate());
-            this.modal.find(this.options.modalCloseBtn).off().on('click',  _.bind(this.closeModal, this));
+            this.modal.find(this.options.modalCloseBtn).off().on('click',  _.bind(this.closeModal, this, false));
 
             if (this.options.validation) {
                 this.setValidationClasses();
@@ -152,23 +152,21 @@ define([
         /**
          * Close modal window
          */
-        closeModal: function (event, result) {
+        closeModal: function (result) {
             var value;
 
-            result = result || false;
-
             if (result) {
                 if (this.options.validation && !this.validate()) {
                     return false;
                 }
 
                 value = this.modal.find(this.options.promptField).val();
-                this.options.actions.confirm.call(event, value);
+                this.options.actions.confirm.call(this, value);
             } else {
-                this.options.actions.cancel.call(event, result);
+                this.options.actions.cancel.call(this, result);
             }
 
-            this.options.actions.always(event);
+            this.options.actions.always();
             this.element.bind('promptclosed', _.bind(this._remove, this));
 
             return this._super();
@@ -179,4 +177,3 @@ define([
         return $('<div class="prompt-message"></div>').html(config.content).prompt(config);
     };
 });
-