Skip to content

Commit

Permalink
Modify Report processor to return 500
Browse files Browse the repository at this point in the history
The report processor is currently returning a HTTP 503 status
code; generally used for temporarily failures to connect to a service
such as when that service is in maintenance mode, when an upstream
proxy is unavailable etc.

This commit modifies the report HTTP code to be a 500. The author
believes this to be a better reflection that the error is miscellaneous
in nature, and that action is required in order to change it (i.e.
it is not a temporary condition)
  • Loading branch information
andrewhowdencom authored and AlexWorking committed Mar 20, 2018
1 parent 447a24d commit 72c502f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pub/errors/processor.php
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ public function process503()
public function processReport()
{
$this->pageTitle = 'There has been an error processing your request';
$this->_response->setHttpResponseCode(503);
$this->_response->setHttpResponseCode(500);

$this->showErrorMsg = false;
$this->showSentMsg = false;
Expand Down

0 comments on commit 72c502f

Please sign in to comment.