Skip to content

Commit

Permalink
🐛 Add missing showInStore attributes
Browse files Browse the repository at this point in the history
Add missing showInStore attributes on Braintree configuration as there
are some values that are changeable on store view (Title, Descriptors,
merchant name override) and are not accessible from store view level.
  • Loading branch information
Andreas Schrammel committed Jun 29, 2018
1 parent f947cad commit 75fb28c
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions app/code/Magento/Braintree/etc/adminhtml/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<comment>http://docs.magento.com/m2/ce/user_guide/payment/braintree.html</comment>
<frontend_model>Magento\Paypal\Block\Adminhtml\System\Config\Fieldset\Hint</frontend_model>
</group>
<group id="braintree_required" translate="label" showInDefault="1" showInWebsite="1" sortOrder="5">
<group id="braintree_required" translate="label" showInDefault="1" showInWebsite="1" showInStore="1" sortOrder="5">
<label>Basic Braintree Settings</label>
<attribute type="expanded">1</attribute>
<frontend_model>Magento\Config\Block\System\Config\Form\Fieldset</frontend_model>
Expand Down Expand Up @@ -77,7 +77,7 @@
<backend_model>Magento\Config\Model\Config\Backend\Encrypted</backend_model>
</field>
</group>
<group id="braintree_advanced" translate="label" showInDefault="1" showInWebsite="1" sortOrder="20">
<group id="braintree_advanced" translate="label" showInDefault="1" showInWebsite="1" showInStore="0" sortOrder="20">
<label>Advanced Braintree Settings</label>
<frontend_model>Magento\Config\Block\System\Config\Form\Fieldset</frontend_model>
<field id="braintree_cc_vault_title" translate="label" type="text" sortOrder="20" showInDefault="1" showInWebsite="1" showInStore="0">
Expand Down Expand Up @@ -125,7 +125,7 @@
<config_path>payment/braintree/sort_order</config_path>
</field>
</group>
<group id="braintree_country_specific" translate="label" showInDefault="1" showInWebsite="1" sortOrder="30">
<group id="braintree_country_specific" translate="label" showInDefault="1" showInWebsite="1" showInStore="0" sortOrder="30">
<label>Country Specific Settings</label>
<frontend_model>Magento\Config\Block\System\Config\Form\Fieldset</frontend_model>
<field id="allowspecific" translate="label" type="allowspecific" sortOrder="200" showInDefault="1" showInWebsite="1" showInStore="0">
Expand All @@ -146,7 +146,7 @@
<config_path>payment/braintree/countrycreditcard</config_path>
</field>
</group>
<group id="braintree_paypal" translate="label" showInDefault="1" showInWebsite="1" sortOrder="40">
<group id="braintree_paypal" translate="label" showInDefault="1" showInWebsite="1" showInStore="1" sortOrder="40">
<label>PayPal through Braintree</label>
<frontend_model>Magento\Config\Block\System\Config\Form\Fieldset</frontend_model>
<field id="title" translate="label" type="text" sortOrder="20" showInDefault="1" showInWebsite="1" showInStore="1">
Expand Down Expand Up @@ -215,7 +215,7 @@
<config_path>payment/braintree_paypal/skip_order_review</config_path>
</field>
</group>
<group id="braintree_3dsecure" translate="label" showInDefault="1" showInWebsite="1" sortOrder="41">
<group id="braintree_3dsecure" translate="label" showInDefault="1" showInWebsite="1" showInStore="0" sortOrder="41">
<label>3D Secure Verification Settings</label>
<frontend_model>Magento\Config\Block\System\Config\Form\Fieldset</frontend_model>
<field id="verify_3dsecure" translate="label" type="select" sortOrder="150" showInDefault="1" showInWebsite="1" showInStore="0">
Expand All @@ -239,7 +239,7 @@
<config_path>payment/braintree/verify_specific_countries</config_path>
</field>
</group>
<group id="braintree_dynamic_descriptor" translate="label" showInDefault="1" showInWebsite="1" sortOrder="50">
<group id="braintree_dynamic_descriptor" translate="label" showInDefault="1" showInWebsite="1" showInStore="1" sortOrder="50">
<label>Dynamic Descriptors</label>
<comment><![CDATA[Dynamic descriptors are sent on a per-transaction basis and define what will appear on your customers credit card statements for a specific purchase.
The clearer the description of your product, the less likely customers will issue chargebacks due to confusion or non-recognition.
Expand Down

0 comments on commit 75fb28c

Please sign in to comment.