Skip to content

Commit

Permalink
PWA-1506: Billing address parameter 'same_as_shipping' cause error 'T…
Browse files Browse the repository at this point in the history
…he shipping method is missing'

* Updated schema descriptions for "same_as_shipping" and "use_for_shipping"
  • Loading branch information
amolina-adobe committed Jun 25, 2021
1 parent 1b810ac commit 760d84c
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
4 changes: 2 additions & 2 deletions app/code/Magento/QuoteGraphQl/etc/schema.graphqls
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ input SetBillingAddressOnCartInput {
input BillingAddressInput {
customer_address_id: Int
address: CartAddressInput
use_for_shipping: Boolean @doc(description: "Deprecated: use `same_as_shipping` field instead")
same_as_shipping: Boolean @doc(description: "Set billing address same as shipping")
use_for_shipping: Boolean @doc(description: "Indicates whether to additionally set the shipping address based on the provided billing address")
same_as_shipping: Boolean @doc(description: "Indicates whether to set the billing address based on the existing shipping address on the cart")
}

input CartAddressInput {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,6 @@ public function testSetNewBillingAddress()
/**
* Tests that the "use_for_shipping" option sets the provided billing address for shipping as well.
*
* Note: the "use_for_shipping" option has been deprecated.
*
* @magentoApiDataFixture Magento/Customer/_files/customer.php
* @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/customer/create_empty_cart.php
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ public function testSetNewBillingAddress()
/**
* Tests that the "use_for_shipping" option sets the provided billing address for shipping as well.
*
* Note: the "use_for_shipping" option has been deprecated.
*
* @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php
Expand Down

0 comments on commit 760d84c

Please sign in to comment.