Remove unnecessary dependencies and fixed unit test case excessively …

…long variable name
magento · Nov 28, 2017 · 774cb4c · 774cb4c
1 parent 48923e1
commit 774cb4c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/app/code/Magento/Paypal/Test/Unit/Model/ExpressTest.php b/app/code/Magento/Paypal/Test/Unit/Model/ExpressTest.php
@@ -161,7 +161,7 @@ public function testAssignData()
     {
         $transportValue = 'something';
 
-        $extensionAttributeMock = $this->getMockForAbstractClass(
+        $extensionAttribute = $this->getMockForAbstractClass(
             \Magento\Quote\Api\Data\PaymentExtensionInterface::class,
             [],
             '',
@@ -175,7 +175,7 @@ public function testAssignData()
                     Express\Checkout::PAYMENT_INFO_TRANSPORT_BILLING_AGREEMENT => $transportValue,
                     Express\Checkout::PAYMENT_INFO_TRANSPORT_PAYER_ID => $transportValue,
                     Express\Checkout::PAYMENT_INFO_TRANSPORT_TOKEN => $transportValue,
-                    \Magento\Framework\Api\ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY => $extensionAttributeMock
+                    \Magento\Framework\Api\ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY => $extensionAttribute
                 ]
             ]
         );

diff --git a/app/code/Magento/Paypal/view/frontend/web/js/action/set-payment-method.js b/app/code/Magento/Paypal/view/frontend/web/js/action/set-payment-method.js
@@ -4,15 +4,9 @@
  */
 
 define([
-    'jquery',
     'Magento_Checkout/js/model/quote',
-    'Magento_Checkout/js/model/url-builder',
-    'mage/storage',
-    'Magento_Checkout/js/model/error-processor',
-    'Magento_Customer/js/model/customer',
-    'Magento_Checkout/js/model/full-screen-loader',
     'Magento_Checkout/js/action/set-payment-information'
-], function ($, quote, urlBuilder, storage, errorProcessor, customer, fullScreenLoader, setPaymentInformation) {
+], function (quote, setPaymentInformation) {
     'use strict';
 
     return function (messageContainer) {