MC-41987: Fix jQuery.isFunction() (#39)

* MC-41987: Fix jQuery.isFunction() - Replace isFunction() * MC-41987: Fix jQuery.isFunction() - Replace isFunction()
magento · May 20, 2021 · 84a457b · 84a457b
1 parent 3734a9e
commit 84a457b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/app/code/Magento/Catalog/view/adminhtml/web/catalog/product-attributes.js b/app/code/Magento/Catalog/view/adminhtml/web/catalog/product-attributes.js
@@ -47,7 +47,7 @@ define([
                 closed: function () {
                     var doc = self.iframe.get(0).document;
 
-                    if (doc && $.isFunction(doc.execCommand)) {
+                    if (doc && typeof doc.execCommand === 'function') {
                         //IE9 break script loading but not execution on iframe removing
                         doc.execCommand('stop');
                         self.iframe.remove();

diff --git a/app/code/Magento/Checkout/view/frontend/web/js/model/address-converter.js b/app/code/Magento/Checkout/view/frontend/web/js/model/address-converter.js
@@ -99,7 +99,7 @@ define([
                 customAttributesObject;
 
             $.each(addrs, function (key) {
-                if (addrs.hasOwnProperty(key) && !$.isFunction(addrs[key])) {
+                if (addrs.hasOwnProperty(key) && typeof addrs[key] !== 'function') {
                     output[self.toUnderscore(key)] = addrs[key];
                 }
             });

diff --git a/lib/web/mage/backend/validation.js b/lib/web/mage/backend/validation.js
@@ -99,7 +99,7 @@ define([
              * @param {HTMLElement} element
              */
             highlight: function (element) {
-                if ($.validator.defaults.highlight && $.isFunction($.validator.defaults.highlight)) {
+                if ($.validator.defaults.highlight && typeof $.validator.defaults.highlight === 'function') {
                     $.validator.defaults.highlight.apply(this, arguments);
                 }
                 $(element).trigger('highlight.validate');
@@ -109,7 +109,7 @@ define([
              * @param {HTMLElement} element
              */
             unhighlight: function (element) {
-                if ($.validator.defaults.unhighlight && $.isFunction($.validator.defaults.unhighlight)) {
+                if ($.validator.defaults.unhighlight && typeof $.validator.defaults.unhighlight === 'function') {
                     $.validator.defaults.unhighlight.apply(this, arguments);
                 }
                 $(element).trigger('unhighlight.validate');