Skip to content

Commit

Permalink
ENGCOM-4646: magento/graphql-ce#559: Fix misspelling in GetQuoteShipp…
Browse files Browse the repository at this point in the history
…ingAddressIdByReservedQuoteId #560
  • Loading branch information
naydav authored Apr 4, 2019
2 parents d14f470 + d2e21e6 commit a17e30d
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -568,16 +568,16 @@ private function getHeaderMap(string $username = 'customer@example.com', string
}

/**
* @param string $reversedOrderId
* @param string $reservedOrderId
* @param int $customerId
* @return string
*/
private function assignQuoteToCustomer(
string $reversedOrderId = 'test_order_with_simple_product_without_address',
string $reservedOrderId = 'test_order_with_simple_product_without_address',
int $customerId = 1
): string {
$quote = $this->quoteFactory->create();
$this->quoteResource->load($quote, $reversedOrderId, 'reserved_order_id');
$this->quoteResource->load($quote, $reservedOrderId, 'reserved_order_id');
$quote->setCustomerId($customerId);
$this->quoteResource->save($quote);
return $this->quoteIdToMaskedId->execute((int)$quote->getId());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -541,16 +541,16 @@ private function getHeaderMap(string $username = 'customer@example.com', string
}

/**
* @param string $reversedOrderId
* @param string $reservedOrderId
* @param int $customerId
* @return string
*/
private function assignQuoteToCustomer(
string $reversedOrderId = 'test_order_with_simple_product_without_address',
string $reservedOrderId = 'test_order_with_simple_product_without_address',
int $customerId = 1
): string {
$quote = $this->quoteFactory->create();
$this->quoteResource->load($quote, $reversedOrderId, 'reserved_order_id');
$this->quoteResource->load($quote, $reservedOrderId, 'reserved_order_id');
$quote->setCustomerId($customerId);
$this->quoteResource->save($quote);
return $this->quoteIdToMaskedId->execute((int)$quote->getId());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@ public function __construct(
/**
* Get masked quote id by reserved order id
*
* @param string $reversedOrderId
* @param string $reservedOrderId
* @return string
* @throws NoSuchEntityException
*/
public function execute(string $reversedOrderId): string
public function execute(string $reservedOrderId): string
{
$quote = $this->quoteFactory->create();
$this->quoteResource->load($quote, $reversedOrderId, 'reserved_order_id');
$this->quoteResource->load($quote, $reservedOrderId, 'reserved_order_id');

return $this->quoteIdToMaskedId->execute((int)$quote->getId());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ public function __construct(
/**
* Get quote shipping address id by reserved order id
*
* @param string $reversedOrderId
* @param string $reservedOrderId
* @return int
*/
public function execute(string $reversedOrderId): int
public function execute(string $reservedOrderId): int
{
$quote = $this->quoteFactory->create();
$this->quoteResource->load($quote, $reversedOrderId, 'reserved_order_id');
$this->quoteResource->load($quote, $reservedOrderId, 'reserved_order_id');

return (int)$quote->getShippingAddress()->getId();
}
Expand Down

0 comments on commit a17e30d

Please sign in to comment.