MAGETWO-52767: [Github] Not possible to disable DEBUG logging #4362

magento · Jun 13, 2016 · a29f10c · a29f10c
1 parent c0445c4
commit a29f10c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/app/code/Magento/Developer/Model/Logger/Handler/Debug.php b/app/code/Magento/Developer/Model/Logger/Handler/Debug.php
@@ -63,7 +63,7 @@ public function write(array $record)
  $this->state->getMode() === State::MODE_PRODUCTION
  || !$this->scopeConfig->getValue('debug_logging', ScopeInterface::SCOPE_STORE, $storeCode)
  ) {
- return null;
+ return;
  }
 
  parent::write($record);

diff --git a/app/code/Magento/Developer/Test/Unit/Model/Logger/Handler/DebugTest.php b/app/code/Magento/Developer/Test/Unit/Model/Logger/Handler/DebugTest.php
@@ -102,9 +102,7 @@ public function testWriteDisabledByProduction()
  $this->scopeConfigMock->expects($this->never())
  ->method('getValue');
 
- $this->assertNull(
- $this->model->write(['formatted' => false])
- );
+ $this->model->write(['formatted' => false]);
  }
 
  public function testWriteDisabledByConfig()
@@ -120,8 +118,6 @@ public function testWriteDisabledByConfig()
  ->with('debug_logging', ScopeInterface::SCOPE_STORE, 'test_code')
  ->willReturn(false);
 
- $this->assertNull(
- $this->model->write(['formatted' => false])
- );
+ $this->model->write(['formatted' => false]);
  }
 }