ENGCOM-5930: #878 - Deprecated the column increment_id #951

- Merge Pull Request magento/graphql-ce#951 from strell/graphql-ce:2.3-develop-878 - Merged commits: 1. 746038e 2. 225c9f7
magento · Sep 23, 2019 · bcc5890 · bcc5890
2 parents 50a085d + 225c9f7
commit bcc5890
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/app/code/Magento/SalesGraphQl/Model/Resolver/Orders.php b/app/code/Magento/SalesGraphQl/Model/Resolver/Orders.php
@@ -56,6 +56,7 @@ public function resolve(
             $items[] = [
                 'id' => $order->getId(),
                 'increment_id' => $order->getIncrementId(),
+                'order_number' => $order->getIncrementId(),
                 'created_at' => $order->getCreatedAt(),
                 'grand_total' => $order->getGrandTotal(),
                 'status' => $order->getStatus(),

diff --git a/app/code/Magento/SalesGraphQl/etc/schema.graphqls b/app/code/Magento/SalesGraphQl/etc/schema.graphqls
@@ -7,7 +7,8 @@ type Query {
 
 type CustomerOrder @doc(description: "Order mapping fields") {
     id: Int
-    increment_id: String
+    increment_id: String @deprecated(reason: "Use the order_number instaed.")
+    order_number: String! @doc(description: "The order number")
     created_at: String
     grand_total: Float
     status: String

diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Sales/OrdersTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Sales/OrdersTest.php
@@ -38,9 +38,7 @@ public function testOrdersQuery()
 query {
   customerOrders {
     items {
-      id
-      increment_id
-      created_at
+      order_number
       grand_total
       status
     }
@@ -54,27 +52,27 @@ public function testOrdersQuery()
 
         $expectedData = [
             [
-                'increment_id' => '100000002',
+                'order_number' => '100000002',
                 'status' => 'processing',
                 'grand_total' => 120.00
             ],
             [
-                'increment_id' => '100000003',
+                'order_number' => '100000003',
                 'status' => 'processing',
                 'grand_total' => 130.00
             ],
             [
-                'increment_id' => '100000004',
+                'order_number' => '100000004',
                 'status' => 'closed',
                 'grand_total' => 140.00
             ],
             [
-                'increment_id' => '100000005',
+                'order_number' => '100000005',
                 'status' => 'complete',
                 'grand_total' => 150.00
             ],
             [
-                'increment_id' => '100000006',
+                'order_number' => '100000006',
                 'status' => 'complete',
                 'grand_total' => 160.00
             ]
@@ -84,19 +82,19 @@ public function testOrdersQuery()
 
         foreach ($expectedData as $key => $data) {
             $this->assertEquals(
-                $data['increment_id'],
-                $actualData[$key]['increment_id'],
-                "increment_id is different than the expected for order - " . $data['increment_id']
+                $data['order_number'],
+                $actualData[$key]['order_number'],
+                "order_number is different than the expected for order - " . $data['order_number']
             );
             $this->assertEquals(
                 $data['grand_total'],
                 $actualData[$key]['grand_total'],
-                "grand_total is different than the expected for order - " . $data['increment_id']
+                "grand_total is different than the expected for order - " . $data['order_number']
             );
             $this->assertEquals(
                 $data['status'],
                 $actualData[$key]['status'],
-                "status is different than the expected for order - " . $data['increment_id']
+                "status is different than the expected for order - " . $data['order_number']
             );
         }
     }