Skip to content

Commit

Permalink
prevent double shipping method selection
Browse files Browse the repository at this point in the history
There already is a click handler on the <tr>, so there is no need to put
it on the radio input. This prevents selectShippingMethod from being
executed twice.

For more information, see issue #5814.

Closes #5814.
  • Loading branch information
Daniel Sloof committed Jan 11, 2017
1 parent cac91b5 commit ddb77b2
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,7 @@
attr: {
'id': 's_method_' + method.carrier_code + '_' + method.method_code,
'aria-labelledby': 'label_method_' + method.method_code + '_' + method.carrier_code + ' ' + 'label_carrier_' + method.method_code + '_' + method.carrier_code
},
click: $parent.selectShippingMethod"
}"
class="radio"/>
<!--/ko-->
<!-- /ko -->
Expand Down

0 comments on commit ddb77b2

Please sign in to comment.