🔃 [EngCom] Public Pull Requests - 2.1-develop

Accepted Public Pull Requests: - #17003: [Backport] Remove unused comments from _initDiscount() function (by @mageprince) - #17015: [Backport] Fixes white color coding standard. (by @chirag-wagento) - #17018: [Backport] Wrong namespace defined in compare.phtml (by @ronak2ram)
magento · Jul 23, 2018 · ea4008e · ea4008e
2 parents ff04f26 + f2b98b5
commit ea4008e
Show file tree

Hide file tree

Showing 12 changed files with 46 additions and 52 deletions.
diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/addto/compare.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/addto/compare.phtml
@@ -6,7 +6,7 @@
 
 // @codingStandardsIgnoreFile
 
-/** @var $block \Magento\Catalog\Block\Catalog\Product\View\Addto\Compare */
+/** @var $block \Magento\Catalog\Block\Product\View\Addto\Compare */
 ?>
 
 <a href="#" data-post='<?php /* @escapeNotVerified */ echo $block->getPostDataParams();?>'

diff --git a/app/code/Magento/Tax/Block/Sales/Order/Tax.php b/app/code/Magento/Tax/Block/Sales/Order/Tax.php
@@ -260,12 +260,6 @@ protected function _initShipping()
      */
     protected function _initDiscount()
     {
-        //        $store  = $this->getStore();
-        //        $parent = $this->getParentBlock();
-        //        if ($this->_config->displaySales) {
-        //
-        //        } elseif ($this->_config->displaySales) {
-        //        }
     }
 
     /**

diff --git a/app/design/adminhtml/Magento/backend/Magento_Backend/web/css/source/_module-old.less b/app/design/adminhtml/Magento/backend/Magento_Backend/web/css/source/_module-old.less
@@ -14,7 +14,7 @@
     display: inline-block;
     vertical-align: top;
     width: 100%;
-    background-color: #fff;
+    background-color: @color-white;
     border: 1px solid #ada89e;
     border-radius: 2px;
 
@@ -72,7 +72,7 @@
     top: 100%;
     margin: 1px -1px 0 -1px;
     border: 1px solid #cac2b5;
-    background: #fff;
+    background: @color-white;
     box-shadow: 0 2px 4px rgba(0, 0, 0, .2);
     z-index: 990;
 
@@ -229,7 +229,7 @@
 
         > input.ui-autocomplete-loading,
         > input.mage-suggest-state-loading {
-            background: #fff url("@{baseDir}mui/images/ajax-loader-small.gif") no-repeat 190px 50%;
+            background: @color-white url("@{baseDir}mui/images/ajax-loader-small.gif") no-repeat 190px 50%;
         }
     }
 

diff --git a/app/design/adminhtml/Magento/backend/Magento_Catalog/web/css/source/_module-old.less b/app/design/adminhtml/Magento/backend/Magento_Catalog/web/css/source/_module-old.less
@@ -53,7 +53,7 @@
     }
 
     .attribute-change-checkbox {
-        background: #fff;
+        background: @color-white;
         display: block;
         margin-top: 5px;
 

diff --git a/...ign/adminhtml/Magento/backend/Magento_ConfigurableProduct/web/css/source/_module-old.less b/...ign/adminhtml/Magento/backend/Magento_ConfigurableProduct/web/css/source/_module-old.less
@@ -16,7 +16,7 @@
     );
 
     .action.toggle {
-        background: #fff;
+        background: @color-white;
         border-radius: 0 1px 1px 0;
         border: 1px solid #ada89e;
         height: 33px;
@@ -58,7 +58,7 @@
         .action.toggle {
             padding: 0 3px;
             border: 1px solid #b7b2a7;
-            background: #fff;
+            background: @color-white;
             border-radius: 0 1px 1px 0;
             border-left: none;
             height: 50px;
@@ -121,7 +121,7 @@
             width: auto;
 
             .addafter {
-                background: #fff;
+                background: @color-white;
                 border-width: 1px 0 1px 1px;
                 direction: ltr;
                 height: 33px;

diff --git a/app/design/adminhtml/Magento/backend/Magento_Enterprise/web/css/source/_module-old.less b/app/design/adminhtml/Magento/backend/Magento_Enterprise/web/css/source/_module-old.less
@@ -299,7 +299,7 @@
 .invitee_information .data-table tbody tr th,
 .inviter_information .data-table tbody tr td,
 .inviter_information .data-table tbody tr th {
-    background-color: #fff;
+    background-color: @color-white;
     border: 0;
     color: #666;
     padding: 9px 10px 10px;

diff --git a/app/design/adminhtml/Magento/backend/Magento_Ui/web/css/source/_module-old.less b/app/design/adminhtml/Magento/backend/Magento_Ui/web/css/source/_module-old.less
@@ -78,7 +78,7 @@
 
         &.ui-state-active {
             z-index: 2;
-            background: #FFF;
+            background: @color-white;
             padding: 1px (@spacing-m - 1px);
             border: 2px solid #eb5202;
             margin: -1px;

diff --git a/app/design/adminhtml/Magento/backend/web/css/styles-old.less b/app/design/adminhtml/Magento/backend/web/css/styles-old.less
@@ -525,7 +525,7 @@
         right: 0;
         top: 100%;
         border: 1px solid #cac2b5;
-        background: #fff;
+        background: @color-white;
         box-shadow: 0 1px 1px rgba(0, 0, 0, .2);
         z-index: 990;
     }
@@ -789,7 +789,7 @@
         border-radius: 1px;
         padding: 4px;
         color: #303030;
-        background-color: #fff;
+        background-color: @color-white;
         font-weight: 500;
         font-size: 14px;
         height: 33px;
@@ -863,7 +863,7 @@
     input[type="radio"],
     input[type="checkbox"] {
         .lib-css(appearance, none, 1);
-        background: #fff;
+        background: @color-white;
         border-radius: 2px;
         border: 1px solid #adadad;
         cursor: pointer;
@@ -948,7 +948,7 @@
     }
 
     select[disabled] option[selected] {
-        color: #fff;
+        color: @color-white;
         background: #aaa;
     }
 
@@ -1160,7 +1160,7 @@
 
     .fieldset-wrapper,
     .fieldset {
-        background: #fff;
+        background: @color-white;
         border: 0;
         margin: 0;
         padding: 5px 0 38px;
@@ -1578,7 +1578,7 @@
 
     .multiselect-alt .item {
         position: relative;
-        border-top: 1px solid #fff;
+        border-top: 1px solid @color-white;
         cursor: pointer;
     }
 
@@ -1655,7 +1655,7 @@
 
             ~ .addafter strong {
                 display: inline-block;
-                background: #fff;
+                background: @color-white;
                 line-height: 24px;
                 margin: 0 3px 0 0;
                 padding-left: 4px;
@@ -2045,7 +2045,7 @@
         &:before {
             position: absolute;
             content: "";
-            background-color: #fff;
+            background-color: @color-white;
             right: 0;
             top: 0;
             bottom: 0;
@@ -2302,7 +2302,7 @@
     //  --------------------------------------
 
     .preview-window {
-        background: #fff;
+        background: @color-white;
     }
 
     .preview-window .toolbar {
@@ -2462,7 +2462,7 @@
     }
 
     .attribute-popup .page-actions.fixed .page-actions-inner {
-        background: #fff;
+        background: @color-white;
         padding: 0;
         min-width: 100%;
         max-width: 100%;
@@ -2761,7 +2761,7 @@
             border: 1px solid #c9c2b8;
             border-width: 0 0 1px;
             padding: 6px 10px 7px;
-            background: #fff;
+            background: @color-white;
             .style2();
 
             span {
@@ -2773,7 +2773,7 @@
         td {
             border: none;
             padding: 6px 10px 7px;
-            background: #fff;
+            background: @color-white;
         }
 
         tr:last-child td {
@@ -2862,7 +2862,7 @@
 
     .table-fieldset-alt tbody tr:nth-child(odd) td,
     .table-fieldset-alt tbody tr:nth-child(odd):hover td {
-        background: #fff;
+        background: @color-white;
     }
 
     //
@@ -2922,7 +2922,7 @@
     }
 
     .order-details-existing-customer {
-        background: #fff;
+        background: @color-white;
         padding-left: 0;
         position: relative;
         width: 77.9%;
@@ -3039,7 +3039,7 @@
     }
 
     .gift-options-tooltip {
-        background: #fff;
+        background: @color-white;
         border-radius: 5px;
         padding: 10px;
         box-shadow: 0 0 3px rgba(0, 0, 0, .3);
@@ -3198,7 +3198,7 @@
             left: 0;
             margin: 0 8px;
             padding: 10px;
-            background: #fff;
+            background: @color-white;
         }
     }
 
@@ -3390,7 +3390,7 @@
 
     .rma-popup,
     .cms-popup {
-        background: #fff;
+        background: @color-white;
         box-shadow: 0 3px 6px rgba(0, 0, 0, .4);
         cursor: default;
         position: fixed;
@@ -3414,7 +3414,7 @@
     }
 
     .rma-popup .content {
-        background: #fff;
+        background: @color-white;
         border-bottom: 1px solid #ccc;
         max-height: 400px;
         overflow: auto;
@@ -3471,7 +3471,7 @@
     .grid .rma-popup .form-list tr,
     .grid tr.even .rma-popup .form-list tr,
     .grid tr.on-mouse .rma-popup .form-list tr {
-        background: #fff !important;
+        background: @color-white !important;
     }
 
     //
@@ -3885,7 +3885,7 @@
     .defaultSkin {
         table.mceLayout {
             td {
-                background: #fff;
+                background: @color-white;
             }
         }
 

diff --git a/app/design/adminhtml/Magento/backend/web/mui/styles/_table.less b/app/design/adminhtml/Magento/backend/web/mui/styles/_table.less
@@ -360,7 +360,7 @@ td.col-type {
             position: relative;
             border-bottom-right-radius: 0;
             box-shadow: none;
-            background: #fff;
+            background: @color-white;
 
             &:after {
                 position: absolute;
@@ -369,7 +369,7 @@ td.col-type {
                 right: 0;
                 height: 2px;
                 margin-top: -1px;
-                background: #fff;
+                background: @color-white;
                 content: '';
                 z-index: 2;
             }

diff --git a/lib/web/css/docs/source/_buttons.less b/lib/web/css/docs/source/_buttons.less
@@ -524,10 +524,10 @@ button {
     }
     &.example-button-6 {
         .lib-button-s();
-        color: #fff;
+        color: @color-white;
         &:hover,
         &.active {
-            color: #fff;
+            color: @color-white;
         }
     }
 }
@@ -721,13 +721,13 @@ button {
         @_button-padding: @button__padding,
         @_button-gradient-color-start: #1979c3,
         @_button-gradient-color-end: #006bb4,
-        @_button-color: #fff,
+        @_button-color: @color-white,
         @_button-gradient-color-start-hover: #006bb4,
         @_button-gradient-color-end-hover: #1979c3,
-        @_button-color-hover: #fff,
+        @_button-color-hover: @color-white,
         @_button-gradient-color-start-active: #006bb4,
         @_button-gradient-color-end-active: #006bb4,
-        @_button-color-active: #fff,
+        @_button-color-active: @color-white,
         @_button-gradient: true,
         @_button-gradient-direction: vertical,
         @_button-border: @button-primary__border,

diff --git a/lib/web/css/docs/source/_pages.less b/lib/web/css/docs/source/_pages.less
@@ -852,22 +852,22 @@
 .example-pages-3 {
     .lib-pager(
         @_pager-label-display: none,
-        @_pager-color: #fff,
+        @_pager-color: @color-white,
         @_pager-background: @link__color,
-        @_pager-color-visited: #fff,
+        @_pager-color-visited: @color-white,
         @_pager-background-visited: @link__visited__color,
-        @_pager-color-hover: #fff,
+        @_pager-color-hover: @color-white,
         @_pager-background-hover: @link__hover__color,
-        @_pager-color-active: #fff,
+        @_pager-color-active: @color-white,
         @_pager-background-active: @link__active__color,
-        @_pager-current-color: #fff,
+        @_pager-current-color: @color-white,
         @_pager-current-background: @link__visited__color,
         @_pager-action-background: @link__color,
         @_pager-action-background-visited: @link__visited__color,
         @_pager-action-background-hover: @link__hover__color,
         @_pager-action-background-active: @link__active__color,
-        @_pager-action-color: #fff,
-        @_pager-action-color-hover: #fff,
-        @_pager-action-color-active: #fff
+        @_pager-action-color: @color-white,
+        @_pager-action-color-hover: @color-white,
+        @_pager-action-color-active: @color-white
     );
 }
diff --git a/lib/web/css/docs/source/_tables.less b/lib/web/css/docs/source/_tables.less
@@ -677,7 +677,7 @@
 .example-table-5 {
     .lib-table();
     .lib-table-background-color(
-        @_table-background-color: #fff,
+        @_table-background-color: @color-white,
         @_table-head-background-color: #ccf,
         @_table-foot-background-color: #cff,
         @_table-td-background-color: #fcc,