Merge pull request #567 from magento-performance/ACPT-1587

ACPT-1587: fixing static test failures for ACPT-1587
magento · Oct 3, 2023 · eb0d2ed · eb0d2ed
2 parents a495fed + 5029ce9
commit eb0d2ed
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/app/code/Magento/GraphQlNewRelic/Plugin/ReportError.php b/app/code/Magento/GraphQlNewRelic/Plugin/ReportError.php
@@ -19,7 +19,8 @@ class ReportError
     /**
      * @param NewRelicWrapper $newRelicWrapper
      */
-    public function __construct(private NewRelicWrapper $newRelicWrapper) {
+    public function __construct(private NewRelicWrapper $newRelicWrapper)
+    {
     }
 
     /**
@@ -31,8 +32,8 @@ public function __construct(private NewRelicWrapper $newRelicWrapper) {
      * @return null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function beforeHandle(ErrorHandler $subject, array $errors, callable $formatter
-    ): null {
+    public function beforeHandle(ErrorHandler $subject, array $errors, callable $formatter)
+    {
         if (!empty($errors)) {
             $this->newRelicWrapper->reportError($errors[0]); // Note: We only log the first error because performance
         }

diff --git a/app/code/Magento/GraphQlNewRelic/Plugin/ReportException.php b/app/code/Magento/GraphQlNewRelic/Plugin/ReportException.php
@@ -18,7 +18,8 @@ class ReportException
     /**
      * @param NewRelicWrapper $newRelicWrapper
      */
-    public function __construct(private NewRelicWrapper $newRelicWrapper) {
+    public function __construct(private NewRelicWrapper $newRelicWrapper)
+    {
     }
 
     /**
@@ -33,8 +34,8 @@ public function __construct(private NewRelicWrapper $newRelicWrapper) {
     public function beforeCheck(
         ExceptionFormatter $subject,
         \Throwable $exception,
-        string $internalErrorMessage= null
-    ): null {
+        string $internalErrorMessage = null
+    ) {
         $this->newRelicWrapper->reportError($exception);
         return null;
     }

diff --git a/app/code/Magento/GraphQlNewRelic/composer.json b/app/code/Magento/GraphQlNewRelic/composer.json
@@ -6,7 +6,7 @@
         "php": "~8.1.0||~8.2.0",
         "magento/framework": "*",
         "magento/module-new-relic-reporting": "*",
-        "magento/module-graphql": "*"
+        "magento/module-graph-ql": "*"
     },
     "license": [
         "OSL-3.0",

diff --git a/app/code/Magento/GraphQlNewRelic/registration.php b/app/code/Magento/GraphQlNewRelic/registration.php
@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 use Magento\Framework\Component\ComponentRegistrar;