Potential error on order edit page when address has extension attributes

[dankocherga]

Potential error on order edit page when address has extension attributes

Preconditions

1. Magento 2.1.7
2. PHP 7.0.18

Steps to reproduce

1. Suppose you init extension attributes of the order address on the sales_order_address_load_after event (any other way is also ok):

        $address = $observer->getEvent()->getAddress();
        $extensionAttributes = $address->getExtensionAttributes();
        if (!$extensionAttributes) {
            $extensionAttributes = $this->extensionAttributesFactory->create();
            $address->setExtensionAttributes($extensionAttributes);
        }

2. Go to order's admin panel and click "Edit"

Expected result

1. Order edit page opens

Actual result

1. Order edit page fails with the following error: Recoverable Error: Object of class Magento\Sales\Api\Data\OrderAddressExtension could not be converted to string in .../module-sales/Model/AdminOrder/Create.php on line 503

The code on this line does the following:

        $shippingAddress = $order->getShippingAddress();
        if ($shippingAddress) {
            $addressDiff = array_diff_assoc($shippingAddress->getData(), $order->getBillingAddress()->getData());
            unset($addressDiff['address_type'], $addressDiff['entity_id']);
            $shippingAddress->setSameAsBilling(empty($addressDiff));
        }

The problem is that $shippingAddress object could potentially have extension_attributes field in the data and that field is an object (which is correct).
When you diff arrays with object in a field you get the error:

php > var_dump(array_diff_assoc(['foo' => new stdClass], ['foo' => new stdClass]));
PHP Catchable fatal error:  Object of class stdClass could not be converted to string in php shell code on line 1

array_diff_assoc converts values to strings according to the documentation:

Two values from key => value pairs are considered equal only if (string) $elem1 === (string) $elem2 . In other words a strict check takes place so the string representations must be the same.

[magento-engcom-team]

@dankocherga From github code I can only get error that missing argument in $this->extensionAttributesFactory->create() function. When I tried to customize code I would not receive any error. Pls show all your module code.

[dankocherga]

@magento-engcom-team
Please look at this sample module: https://github.com/dankocherga/m2-issue-10438
It adds extension attributes to order's shipping and billing address.
Try creating an order and editing it via admin panel.

[magento-engcom-team]

@dankocherga, thank you for your report.
We've created internal ticket(s) MAGETWO-75789 to track progress on the issue.

[YevSent]

I'm working on it #SQUASHTOBERFEST

[okorshenko]

thank you for your report. The issue has been fixed and delivered to 2.2-develop branch. Will be available with upcoming patch release

[magento-engcom-team]

Hi @dankocherga. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1362 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

• 4705e23
• 6d355e0
• 77f34cf
• 748ab4d
• 90f9d95
• 44ca24f
• f0b7f2b
• c3e1d93
• 4810755
• 4709a22
• a2b9fab
• ac7df33
• 245238d
• 2c153c3
• 48a72fa
• 625f685
• afa4516

The fix will be available with the upcoming 2.3.0 release.