Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BEM class in XML via attribute tag causes class to be rewritten #10645

Closed
Zaylril opened this issue Aug 24, 2017 · 7 comments
Closed

Adding BEM class in XML via attribute tag causes class to be rewritten #10645

Zaylril opened this issue Aug 24, 2017 · 7 comments
Assignees
Labels
bug report Component: Framework/View Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@Zaylril
Copy link

Zaylril commented Aug 24, 2017

Preconditions

  1. Magento 2.2, PHP 7.1

Steps to reproduce

  1. Go to default.xml
  2. Add attribute tag with a class to the body element i.e. <attribute name="class" value="background-color--white"/>
  3. Clear cache and reload page

Expected result

  1. Class should be rendered as it is added in the XML i.e. background-color--white

Actual result

  1. Classes with -- in them are replaced with a single - so result appears as background-color-white
@daniloargentiero
Copy link

Hi Zaylrill,
I found a solution. Tomorrow I'll send the pull request to Magento and then I'll post the solution here.

Please hold on!

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-71933

@magento-team magento-team added 2.2.0-rc2 Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Aug 28, 2017
@miguelbalparda miguelbalparda self-assigned this Aug 29, 2017
@miguelbalparda
Copy link
Contributor

This should be fixed by #10655

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@dmytro-ch dmytro-ch added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Mar 17, 2019
@magento-engcom-team
Copy link
Contributor

@dmytro-ch Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 17, 2019
@dmytro-ch dmytro-ch added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Framework/View labels Mar 17, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @dmytro-ch
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98747 were created

Issue Available: @dmytro-ch, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team
Copy link
Contributor

Hi @Zaylril. Thank you for your report.
The issue has been fixed in #21804 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 20, 2019
magento-engcom-team added a commit that referenced this issue Mar 20, 2019
…tag. Public #21804

 - Merge Pull Request #21804 from amol2jcommerce/magento2:2.2-develop-PR-port-10655
 - Merged commits:
   1. ab7aee9
   2. 743c034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Framework/View Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests

7 participants