Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html editor #11109

Closed
smartstoremx opened this issue Sep 28, 2017 · 5 comments
Closed

html editor #11109

smartstoremx opened this issue Sep 28, 2017 · 5 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@smartstoremx
Copy link

after update you get this
writehtml
writehtml
after update you get this

Preconditions

Magento 2.2

  1. Content - Blocks

Steps to reproduce

  1. Goto Content-Blocks
  2. Edit my slider block using the html editor
  3. Write many likes see the picture 1. I am using this:
  4. I press update
  5. When I open to see the code this change to:
    a class="camera_caption_txt--btn"
    href="http://localhost/s2/admin2/cms/wysiwyg/directive/___directive/e3tzdG9yZSB1cmw9J21lbi5odG1sJ319/key/60e2edd93d70c88b278b9281a60f6ee9a83b4c797978b796f7ab8960ee8637c7/">Shop now!

writehtml

Expected result

Actual result

  1. [Screenshot, logs]
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 28, 2017
@smartstoremx
Copy link
Author

Magento 2.1.9 works fine but in Magento 2.2 it fails when you update any html in the block area. I hope it helps.

@smartstoremx
Copy link
Author

I expected my html do not change when I save it.

@renttek
Copy link

renttek commented Sep 30, 2017

Hey,

It seems, that this conversion of directives to urls is intended.
(If this wouldn't be converted on save, then it had to be done on rendering, which may decreased performance of initial page delivery)

In /lib/web/mage/adminhtml/wysiwyg/tiny_mce/setup.js:410 is a function/method "makeDirectiveUrl" which is converts all directives in html attributes.
This is triggered by "beforeSetContent" > "encodeContent" > "encodeDirectives" in the same file.

Beside this, is there a error when you try to save/update the content?
If yes, is there an explicit error message shown?

@PieterCappelle
Copy link
Contributor

Hi, this is related to this issue #10417 and fixed with my PR #11048

@okorshenko
Copy link
Contributor

@smartstoremx thank you for your report. The issue is already fixed in 2.2-develop branch (PR: #11048 by @PieterCappelle) and will be available in the Magento 2.2.2 release

@okorshenko okorshenko added Fixed in 2.2.x The issue has been fixed in 2.2 release line and removed Progress: needs update labels Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

5 participants