Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10417 #11048

Merged
merged 4 commits into from
Oct 4, 2017
Merged

Fix #10417 #11048

merged 4 commits into from
Oct 4, 2017

Conversation

PieterCappelle
Copy link
Contributor

@PieterCappelle PieterCappelle commented Sep 26, 2017

When adding images in CMS Pages / Blocks or Catalog and Category the path to the image is incorrect. When you insert image in 2.1.8, we get <p><img src="{{media url="wysiwyg/Hond.jpg"}}" width="1024" height="683" /></p> when we insert image in 2.1.9 <p><img src="http://local.magento/admin/cms/wysiwyg/directive/___directive/e3ttZWRpYSB1cmw9Ind5c2l3eWcvVmVsZC5qcGcifX0%2C/key/d3f89696a93152f6d352e5d5cb391180a27c8a7924d9fe3b583d3e9f03d00753/" width="959" height="1024" /></p>

The issue is also a problem in 2.2-develop. This fix is for 2.2-develop. Will create backport voor 2.1-develop branch.

Fixed Issues (if relevant)

  1. Wysywig editor shows broken image icons #10417

Manual testing scenarios

  1. Go to CMS Pages.
  2. Add image
  3. Check the path (show/hide editor)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

heyitsroberthe and others added 4 commits September 12, 2017 20:36
[mpi] MAGETWO-72551: Update version in composer to 2.2.1-dev for 2.2-develop branch
@vrann vrann self-assigned this Sep 28, 2017
@vrann vrann added this to the September 2017 milestone Sep 28, 2017
@vrann vrann reopened this Sep 29, 2017
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 29, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ PieterCappelle
❌ paliarush
❌ viktym

@PieterCappelle
Copy link
Contributor Author

Please merge this. I will create backport for 2.1.

@PieterCappelle PieterCappelle mentioned this pull request Oct 2, 2017
@okorshenko okorshenko merged commit 202dd82 into magento:2.2-develop Oct 4, 2017
okorshenko pushed a commit that referenced this pull request Oct 4, 2017
@PieterCappelle
Copy link
Contributor Author

Thanks. I'll create backport to 2.1 branch.

@Vishrootways
Copy link

How to solve this error in Magento 2.1.8 version? Please help us if anyone know.

@treii28
Copy link

treii28 commented Jun 4, 2018

I'm on v2.2.2 and still experiencing this issue? What is necessary to resolve it as from what I'm reading here, it's supposed to be fixed in my version. Furthermore, if and when these links sneak into the database, they create hung apache threads whenever a page tries to access one and the things linger in a 'closing' status on the server and eat up 100% cpu until I kill -HUP them manually. I want it fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.