Going to '/admin' while using storecodes in url and a different adminhtml url will throw exception

[koenner01]

If you are using an adminhtml url that is different from 'admin' and set the 'Add Store Code to Urls' to 'Yes', going to '/admin' will throw an exception

Preconditions

1. PHP7.0
2. M2.1.9 CE (we also tested 2.1.7 CE and 2.2.0 CE)

Steps to reproduce

1. use a different url than 'admin' for the adminhtml
2. set 'Stores' > 'Configuration' > 'General' > 'Web' > 'Add Store Code to Urls' to 'Yes'
3. go to '/admin' url

Expected result

1. Page should go to the no-route or at least show 404

Actual result

1. Page tries to go to the homepage with the current store set to 'admin'

We did some debugging already and found that in \Magento\Store\App\Request\PathInfoProcessor the current store is being set to 'admin'.

public function process(\Magento\Framework\App\RequestInterface $request, $pathInfo)
{
    $pathParts = explode('/', ltrim($pathInfo, '/'), 2);
    $storeCode = $pathParts[0];
    try {
        /** @var \Magento\Store\Api\Data\StoreInterface $store */
        $store = $this->storeManager->getStore($storeCode);
    } catch (NoSuchEntityException $e) {
        return $pathInfo;
    }
    if ($store->isUseStoreInUrl()) {
        if (!$request->isDirectAccessFrontendName($storeCode)) {
            $this->storeManager->setCurrentStore($storeCode);
            $pathInfo = '/' . (isset($pathParts[1]) ? $pathParts[1] : '');
            return $pathInfo;
        } elseif (!empty($storeCode)) {
            $request->setActionName('noroute');
            return $pathInfo;
        }
        return $pathInfo;
    }
    return $pathInfo;
}

'admin' will be treated as a valid storecode because the store table in the database contains this value for the store with id 0

[koenner01]

This was already reported in #9947 but closed because of 'inability to reproduce'

[magento-engcom-team]

@koenner01, thank you for your report.
We've created internal ticket(s) MAGETWO-80591 to track progress on the issue.

[sylvainraye]

I'm working on it #SQUASHTOBERFEST

[okorshenko]

The issue has been fixed and delivered to 2.2-develop branch. Will be available with 2.2.2 release

[magento-team]

Internal ticket to track issue progress: MAGETWO-81995

[magento-engcom-team]

Hi @koenner01. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1289 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

• b415941
• 7369261
• dce1c66
• 95ed67e
• 05fcdd1
• 8b1a297
• 90addb7
• d5c9eef
• 6ec6271
• f0af87e
• 2497062
• 1f7347f
• 0d151c4
• 07982fd
• 617da6c
• 39ed21f
• 9aa036d
• fda37ef
• 47b1091
• ef6bada
• 809ec05

The fix will be available with the upcoming patch release.

[sidolov]

Hi @koenner01. Thank you for your report.
The issue has been fixed in #17243 by @mageprince in 2.1-develop branch
Related commit(s):

• c5d85e0cfbd7e38461a782c43eef69805a430b76
• f9696c964d21a3cfef60cffa6b23edf9a1a6be59

The fix will be available with the upcoming 2.1.15 release.