Product configuration creator does not warn about invalid SKUs

[JanisE]

Product configuration creator does not warn about invalid SKUs before attempting to save/create the configuration products, thus losing the product configurations set up.

Preconditions

1. Magento CE 2.2.0 with sample data is installed by Composer.

Steps to reproduce

1. In Admin go to Stores -> Attributes -> Product -> Add New Attribute
2. Create an attribute with input type "Text Swatch" and values "Base" and "With Free Storage Kit" (sufficiently long).
3. In Admin go to: Catalog -> Products -> Add Product
4. Set name to "Sony Alpha a7R III Mirrorless Digital Camera (Body only)" e.i. something sufficiently long, near 64 characters, which is the limit for SKU field.
5. Leave the SKU as automatically filled (the same as the name).
6. (If you would append " (With Free Storage Kit)" to the name, the SKU field would appear red/invalid warning about the maximum length of 64 characters.)
7. Save the product.
8. Open that same product and click on "Create Configurations".
9. Choose the attribute that was just created and "Next".
10. Select both swatch values and "Next".
11. Select whatever images, price, quantity and "Next".
12. Click on "Generate Products".

Expected result

1. There should be warnings about invalid (too long) SKUs.
2. "Save" button would not work unless the (automatically generated from name + text swatch value) SKUs are edited to be valid (shortened).

Actual result

1. There are no warnings about invalid SKUs.
2. Clicking "Save" refreshes the page (losing the unsaved configurations).
3. Error message 'Product with SKU " Sony Alpha a7R III Mirro -With Free Storage Kit-With Free Storage Kit" does not exist' is displayed.

[magento-engcom-team]

@JanisE, thank you for your report.
We've created internal ticket(s) MAGETWO-83176 to track progress on the issue.

[zamoroka]

#mageconf

[TomashKhamlai]

Hello, @dmanners, I hope the comment here will save some time.
The actual behavior of the Magento application after the fix was applied is slightly different than desired expectations described in this ticket.

Here is what was done and what should be done according to the issue description:

• There is no error because the product can't be saved
• Unsaved configurations are not lost
• There should be warnings about invalid (too long) SKUs after click on "Generate Products"

How it works now:

1. In Admin go to Stores -> Attributes -> Product -> Add New Attribute
2. Create an attribute with input type "Text Swatch" and values "Base" and "With Free Storage Kit" (sufficiently long)
3. In Admin go to: Catalog -> Products -> Add Product
4. Set name to "Sony Alpha a7R III Mirrorless Digital Camera (Body only)" e.i. something sufficiently long, near 64 characters, which is the limit for SKU field
5. Leave the SKU as automatically filled (the same as the name)
6. (If you would append " (With Free Storage Kit)" to the name, the SKU field would appear red/invalid warning about the maximum length of 64 characters)
7. Save the product
8. Open that same product and click on "Create Configurations"
9. Choose the attribute that was just created and "Next"
10. Select both swatch values and "Next"
11. Select whatever images, price, quantity and "Next"
12. Click on "Generate Products"
13. Click on "Save"
14. Choose an option from 'Choose Affected Attribute Set' popup and click 'Confirm'
15. Close the popup if validation appeared and change it to be shorter then 64

Can we accept this as it removes errors and improves the user experience?

[zamoroka]

This validation was added trough to Magento way.
The same is already done for other fields, e.g. in price you can set -10$ and validation will proceed after "Save" button.
Also, your flow is not working if you put longer value to sku after "Create Configurations"

[okorshenko]

Hi @JanisE. Thank you for your report.
The issue has been fixed in #12737 by @zamoroka in 2.2-develop branch
Related commit(s):

• 5cf0d34
• 7418f1a

The fix will be available with the upcoming patch release.

[okorshenko]

Hi @JanisE. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1298 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

• 54301a8
• 402b719
• 3837f27
• 031e23e
• aa267f4
• 934818d
• 6bed7d4
• 72b2794
• 4e64c41
• d3feb28
• 7aeccea
• b857c02
• a75bf23
• ab2e579
• d904690
• a821c7a
• 68ac4c0
• 93fe4d1
• f43fd4b
• 2c52a8f

The fix will be available with the upcoming 2.3.0 release.