Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default trigger coupon via URL #120

Closed
seansan opened this issue Nov 7, 2012 · 10 comments
Closed

Default trigger coupon via URL #120

seansan opened this issue Nov 7, 2012 · 10 comments
Labels
Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@seansan
Copy link

seansan commented Nov 7, 2012

Hi - can we enable trigger coupon via URL in Magento 2?

http://www.drewgillson.com/blog/how-to-apply-magento-coupon-codes-automatically/

@magento-team
Copy link
Contributor

Hello. This is very interesting feature. Would you be able to provide code and test for it - we should then be able to incorporate that into Magento code.

@seansan
Copy link
Author

seansan commented Nov 7, 2012

Did you Find the link in the request

Code included in a gist on github. In the post.

Sent from my iPhone.

On 7 nov. 2012, at 22:01, mage2-team notifications@github.com wrote:

Hello. This is very interesting feature. Would you be able to provide code
and test for it - we should then be able to incorporate that into Magento
code.


Reply to this email directly or view it on
GitHubhttps://github.com//issues/120#issuecomment-10164854.

@magento-team
Copy link
Contributor

Hello. Yes - but it is written as an extension not part of the core system. Would you/someone be able to provide it as a pull request for Magento 2 code, preferably with tests?

@seansan
Copy link
Author

seansan commented Nov 9, 2012

In am sorry. I think think this supersedes my skills

Sent from my iPhone.

On 8 nov. 2012, at 22:12, mage2-team notifications@github.com wrote:

Hello. Yes - but it is written as an extension not part of the core system.
Would you/someone be able to provide it as a pull request for Magento 2
code, preferably with tests?


Reply to this email directly or view it on
GitHubhttps://github.com//issues/120#issuecomment-10205068.

@magento-team
Copy link
Contributor

Hello. Such functionality is already available just with a different URL
http://localhost.localdomain/checkout/cart/couponPost/?coupon_code=coupon&return_url=http://localhost.localdomain/simple-1.html

You can also remove a coupon with http://localhost.localdomain/checkout/cart/couponPost/?remove=1

I will close the issue. Please comment if you would like to add any more information.

@seansan
Copy link
Author

seansan commented Dec 11, 2012

I would advise to not close this issue. The devil is in the detail.

When you send a customer through external link with a coupon code (as above suggests) then this will never work. Because of the simple reason that th external customer hsa nothing in the shopping cart. Try it yourself.

What we need to do and what our link with coding suggest is that

  1. if the cart is not empty follow use case as above (link from mage2-team)

  2. if not, then save the coupon code and activate once the customer adds a product automatically

  3. but do check if it would be a valid code, and if so show an update message confirming customer that the couon code has been received (and indirectly applied)

I hope you understand what I am getting at. It is a small difference in logic, but a huge difference in outcome

Thank you - please open the call again and add to timeline

@ghostnumber7
Copy link

seansan is right, it works only if you have products in your cart. If you need to refer a non customer from some other place with a discount, for example, it's useless. Coupon codes should stick until used or removed from cart by hand. That would make everything work

vpelipenko pushed a commit to vpelipenko/magento2 that referenced this issue Mar 5, 2015
@magentoatlinksture
Copy link

I found a very good extension that supports discount link and link click report also. It is working very well in almost all magento versions. You can find it here: http://codecanyon.net/item/discount-coupon-code-link-extension-for-magento/12744606?ref=themezaa

slavvka added a commit that referenced this issue Nov 12, 2015
magento-engcom-team pushed a commit that referenced this issue Apr 13, 2018
MAGETWO-89443: Release New Version of ZF1
@sidolov
Copy link
Contributor

sidolov commented Jul 24, 2018

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jul 24, 2018
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jul 24, 2018
magento-engcom-team added a commit that referenced this issue Oct 27, 2018
…n on dropdown filters. #120

 - Merge Pull Request magento-engcom/import-export-improvements#120 from valentinboyanov/import-export-improvements:MAGETWO-34709-fix-select-type-filter
 - Merged commits:
   1. e258878
@duffner
Copy link

duffner commented Aug 31, 2019

@magento-admin & @magento-engcom-team Was this added into the 2.3 release?

slavvka pushed a commit that referenced this issue May 4, 2020
All System Configuration settings should be on Global level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

7 participants