Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Disable Advanced Reporting #12866

Closed
nfourteen opened this issue Dec 23, 2017 · 18 comments
Closed

Can't Disable Advanced Reporting #12866

nfourteen opened this issue Dec 23, 2017 · 18 comments
Assignees
Labels
Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@nfourteen
Copy link
Contributor

Preconditions

  1. Magento 2.2.2

Steps to reproduce

  1. After a fresh install of version 2.2.2, a system message was received that Synchronization Failed with Magento Business Intelligence (I don't remember the exact message).
  2. To prevent further synchronization error messages, go to Stores > Configuration > General > Advanced Reporting and change Advanced Reporting Service to Disable
  3. Press Save Config

Expected result

  1. The advanced reporting capabilities should be disabled.

Actual result

  1. The following weird error message is received: Please select a vertical.
  2. The advanced reporting capabilities revert back to being enabled.

Reason and Proposed Solutions

The error is thrown from Magento\Analytics\Model\Config\Backend\Vertical::beforeSave() method because I did not select an Industry under Industry Data. That defaults to --Please Select-- and is an empty value, so beforeSave() behaves as it should.

Since the Advanced Reporting needs an external account and service, it should default to Disable on new installs. However, if it was Magento's intention to have it enabled for all new installs, then 1) the logic should be changed so an empty value for the Industry can be provided when Advanced Reporting Service is set to Disable and Save Config is pressed or 2) a more detailed error message should be displayed so merchants understand that an Industry must be provided, even to Disable the Advanced Reporting Service.

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 23, 2017
@PieterCappelle
Copy link
Contributor

Hi @nfourteen, could you create PR? Thanks!

@nfourteen
Copy link
Contributor Author

Hi @PieterCappelle, I just submitted the pull request.

@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Dec 26, 2017
@magento-engcom-team
Copy link
Contributor

@nfourteen, thank you for your report.
We've created internal ticket(s) MAGETWO-86006 to track progress on the issue.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Dec 26, 2017
@tony-sar
Copy link

tony-sar commented Jan 2, 2018

Select Disable and also select Industry data and click on save it should save . I think vertical message relate to the industry data

@jzahedieh
Copy link

image

And even when you disable it the message shows in the dashboard, this is in really bad taste Magento, promoting 3rd party services on the homepage of the admin interface without being able to disable it!

All you need to do is add ifconfig="analytics/general/enabled" to vendor/magento/module-analytics/view/adminhtml/layout/adminhtml_dashboard_index.xml

@adamlavery
Copy link

Agree with the sentiment here. New features like this should be by default disabled.

@fwolfst
Copy link

fwolfst commented Jan 5, 2018

Nobody is scared that this is a sign that the developers are in need (the waving flag on the sinking ship)? ;) But fully agree. Especially together with #12828 where this actually drives away users customers. Anyways, thanks for the PR @nfourteen

@gfxguru
Copy link

gfxguru commented Feb 15, 2018

New features disabled by default. That's a joke right? This is another attempt to reach an audience. They've been doing it for years and I'm tired of it.

@AgentGod
Copy link

AgentGod commented Apr 5, 2018

I think there should be option to totally disable such external services, dotMailer is the other one

@lano-vargas
Copy link

Totally nonsense! Some sort of dictation? 2.2.2 having this client does not like.

@ob7
Copy link

ob7 commented Jul 4, 2018

2.2.6 - still an issue

@ask694
Copy link

ask694 commented Jul 12, 2018

Any solution for this issue? I had just disable the Magento_Analytics by the below command,

php bin/magento module:disable Magento_Analytics

and php bin/magento setup:di:compile

now no more error notifications from Business Intelligence.

@ghost
Copy link

ghost commented Aug 9, 2018

Is this module taking data from stores regardless if you have a paid BI account at all ?

@mikelevy300
Copy link

I'd also really like to know if data from my stores is being sent to BI without an account. There's all kinds of privacy implications if data is being sent to Magento 1) without any kind of notification to admin users and 2) without the ability to disable it without error. If data is being shipped, I'd like to know what is being shipped b/c again, privacy issues.

@Flipmediaco
Copy link

Magento 2.2.6

Attempting to disable Advanced Reporting...

Save Config "Advanced Reporting Service" to "Disable" Returns "You saved the configuration." but select option "Advanced Reporting Service" remains "Enable"

Reviewing configuration in mysql "core_config_data" the item path "analytics/subscription/enabled" shows value "0" after configuration saved with "Advanced Reporting Service" set to "Disable".

The display of "Advanced Reporting Service" is not correctly reflecting the "Disable" status.

@slavvka
Copy link
Member

slavvka commented Oct 23, 2018

Duplicate of #15259

@slavvka slavvka marked this as a duplicate of #15259 Oct 23, 2018
@slavvka slavvka closed this as completed Oct 23, 2018
@rotatingelectrics
Copy link

rotatingelectrics commented Jan 11, 2019

I just hid it in the css. In my case it was the file

/pub/static/adminhtml/Magento/backend/en_US/css/styles.css

from

.dashboard-advanced-reports {
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
border-color: #e3e3e3;
border-style: solid;
border-width: 1px 0;
margin-bottom: 3rem;
padding: 2.5rem 0;
}

to

.dashboard-advanced-reports {
display: none;
}

@patrickpeng2091
Copy link

jzahedieh

edit: vendor/magento/module-analytics/view/adminhtml/layout/adminhtml_dashboard_index.xml

<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd"> <body> <referenceContainer name="content"> <block ifconfig="analytics/general/enabled" template="Magento_Analytics::dashboard/section.phtml" class="Magento\Backend\Block\Template" name="analytics_service_external_link" before="-"/> </referenceContainer> </body> </page>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests