Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced Reporting > Unable to disable without providing Industry value #15259

Closed
Detzler opened this issue May 16, 2018 · 3 comments
Closed

Advanced Reporting > Unable to disable without providing Industry value #15259

Detzler opened this issue May 16, 2018 · 3 comments
Assignees
@shaandg
Labels
Component: Analytics Event: dmcdindia Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Detzler
Copy link

Detzler commented May 16, 2018

Preconditions

  1. Magento 2.2.3
  2. PHP7.1

Steps to reproduce

  1. Goto Backend > Stores > Configuration > General > Advanced Reporting
  2. Save config (while Industry is not provided)

Expected result

  1. One should be able to save without providing the Industry value

Actual result

  1. Can't save. A message appears: "Please select a vertical."

After selecting an Industry (vertical) the config gets saved. The field shouldn't be a required field, when trying to disable.

bildschirmfoto 2018-05-16 um 15 29 11
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 16, 2018
@sunilit42
Copy link
Contributor

I am working on this at #dmcdindia

@sunilit42 sunilit42 mentioned this issue May 19, 2018
Merged
@shaandg shaandg self-assigned this May 21, 2018
@shaandg shaandg mentioned this issue May 21, 2018
Closed
4 tasks
@magento-engcom-team magento-engcom-team added the Progress: PR Created Indicates that Pull Request has been created to fix issue label May 26, 2018
@engcom-backlog-nickolas engcom-backlog-nickolas added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Analytics labels Jul 20, 2018
@okorshenko
Copy link
Contributor

Hi @Detzler. Thank you for your report.
The issue has been fixed in #15366 by @sunilit42 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 23, 2018
@slavvka slavvka mentioned this issue Oct 23, 2018
Closed
@mage2pratik mage2pratik mentioned this issue Oct 24, 2018
Merged
@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Oct 27, 2018
@sidolov
Copy link
Contributor

sidolov commented Oct 27, 2018

Hi @Detzler. Thank you for your report.
The issue has been fixed in #18782 by @mage2pratik in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaandg shaandg

Labels
Component: Analytics Event: dmcdindia Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Detzler @sunilit42 @okorshenko @sidolov @shaandg @magento-engcom-team @engcom-backlog-nickolas