Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] 15259 : Unable to disable without providing Industry value #18782

Merged
merged 1 commit into from
Oct 27, 2018
Merged

[Forwardport] 15259 : Unable to disable without providing Industry value #18782

merged 1 commit into from
Oct 27, 2018

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Oct 24, 2018 •
edited by sidolov
Loading

Original Pull Request

#15366

Issue :- #15259

Description:-
Solved By:- Adding dependency on the Enabled or disabled field.

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@slavvka slavvka self-assigned this Oct 24, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 24, 2018
@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-3263 has been created to process this Pull Request

@sidolov sidolov mentioned this pull request Oct 27, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 6862c04 into magento:2.3-develop Oct 27, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 27, 2018
ENGCOM-3263: [Forwardport] 15259 : Unable to disable without providin…
92e3572 
…g Industry value #18782
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavvka slavvka slavvka approved these changes

Assignees

@slavvka slavvka

Labels
Component: Analytics Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@mage2pratik @magento-engcom-team @slavvka @sunilit42