Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review/product/listAjax/id/{{non existent id}/ #13102

Closed
ruthgeridema opened this issue Jan 10, 2018 · 8 comments
Closed

review/product/listAjax/id/{{non existent id}/ #13102

ruthgeridema opened this issue Jan 10, 2018 · 8 comments
Assignees
@ananth-iyer
Labels
Event: dmcdindia Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@ruthgeridema
Copy link

ruthgeridema commented Jan 10, 2018 •
edited
Loading

Preconditions

  1. All magento 2 versions

Steps to reproduce

  1. Visit review/product/listAjax/id/{{non existent id}/

Expected result

  1. I would expect a 404 not found

Actual result

https://i.gyazo.com/c0c9b0218b7a99c7148f8dab67296671.png
An exception which triggers a 503 HTTP status code

a:4:{i:0;s:25:"Cannot initialize product";i:1;s:9760:"#0 /data/web/magento2/var/generation/Magento/Review/Controller/Product/ListAjax/Interceptor.php(24): Magento\Review\Controller\Product\ListAjax->execute()
#1 /data/web/magento2/vendor/magento/framework/App/Action/Action.php(102): Magento\Review\Controller\Product\ListAjax\Interceptor->execute()
#2 /data/web/magento2/vendor/magento/module-review/Controller/Product.php(169): Magento\Framework\App\Action\Action->dispatch(Object(Magento\Framework\App\Request\Http))
#3 /data/web/magento2/vendor/magento/framework/Interception/Interceptor.php(74): Magento\Review\Controller\Product->dispatch(Object(Magento\Framework\App\Request\Http))
#4 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(70): Magento\Review\Controller\Product\ListAjax\Interceptor->___callParent('dispatch', Array)
#5 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Review\\...', 'dispatch', Object(Magento\Review\Controller\Product\ListAjax\Interceptor), Array, 'contextPlugin')
#6 /data/web/magento2/vendor/magento/module-store/App/Action/Plugin/Context.php(106): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#7 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(67): Magento\Store\App\Action\Plugin\Context->aroundDispatch(Object(Magento\Review\Controller\Product\ListAjax\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#8 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Review\\...', 'dispatch', Object(Magento\Review\Controller\Product\ListAjax\Interceptor), Array, 'customer-segmen...')
#9 /data/web/magento2/vendor/magento/module-customer-segment/Model/App/Action/ContextPlugin.php(81): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#10 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(67): Magento\CustomerSegment\Model\App\Action\ContextPlugin->aroundDispatch(Object(Magento\Review\Controller\Product\ListAjax\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#11 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Review\\...', 'dispatch', Object(Magento\Review\Controller\Product\ListAjax\Interceptor), Array, 'customer-app-ac...')
#12 /data/web/magento2/vendor/magento/module-customer/Model/App/Action/ContextPlugin.php(61): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#13 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(67): Magento\Customer\Model\App\Action\ContextPlugin->aroundDispatch(Object(Magento\Review\Controller\Product\ListAjax\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#14 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Review\\...', 'dispatch', Object(Magento\Review\Controller\Product\ListAjax\Interceptor), Array, 'storeCheck')
#15 /data/web/magento2/vendor/magento/module-store/App/Action/Plugin/StoreCheck.php(44): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#16 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(67): Magento\Store\App\Action\Plugin\StoreCheck->aroundDispatch(Object(Magento\Review\Controller\Product\ListAjax\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#17 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Review\\...', 'dispatch', Object(Magento\Review\Controller\Product\ListAjax\Interceptor), Array, 'weee-app-action...')
#18 /data/web/magento2/vendor/magento/module-weee/Model/App/Action/ContextPlugin.php(112): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#19 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(67): Magento\Weee\Model\App\Action\ContextPlugin->aroundDispatch(Object(Magento\Review\Controller\Product\ListAjax\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#20 /data/web/magento2/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Review\\...', 'dispatch', Object(Magento\Review\Controller\Product\ListAjax\Interceptor), Array, 'tax-app-action-...')
#21 /data/web/magento2/vendor/magento/module-tax/Model/App/Action/ContextPlugin.php(91): Magento\Review\Controller\Product\ListAjax\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#22 /data/web/magento2/vendor/magento/framework/Interception/Interceptor.php(142): Magento\Tax\Model\App\Action\ContextPlugin->aroundDispatch(Object(Magento\Review\Controller\Product\ListAjax\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#23 /data/web/magento2/var/generation/Magento/Review/Controller/Product/ListAjax/Interceptor.php(39): Magento\Review\Controller\Product\ListAjax\Interceptor->___callPlugins('dispatch', Array, Array)
#24 /data/web/magento2/vendor/magento/framework/App/FrontController.php(55): Magento\Review\Controller\Product\ListAjax\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#25 /data/web/magento2/vendor/magento/framework/Interception/Interceptor.php(74): Magento\Framework\App\FrontController->dispatch(Object(Magento\Framework\App\Request\Http))
#26 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(70): Magento\Framework\App\FrontController\Interceptor->___callParent('dispatch', Array)
#27 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'requestPreproce...')
#28 /data/web/magento2/vendor/magento/module-store/App/FrontController/Plugin/RequestPreprocessor.php(94): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#29 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(67): Magento\Store\App\FrontController\Plugin\RequestPreprocessor->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#30 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'install')
#31 /data/web/magento2/vendor/magento/framework/Module/Plugin/DbStatusValidator.php(69): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#32 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(67): Magento\Framework\Module\Plugin\DbStatusValidator->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#33 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'front-controlle...')
#34 /data/web/magento2/vendor/magento/module-page-cache/Model/App/FrontController/VarnishPlugin.php(55): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#35 /data/web/magento2/vendor/magento/framework/Interception/Chain/Chain.php(67): Magento\PageCache\Model\App\FrontController\VarnishPlugin->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#36 /data/web/magento2/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'front-controlle...')
#37 /data/web/magento2/vendor/magento/module-page-cache/Model/App/FrontController/BuiltinPlugin.php(68): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#38 /data/web/magento2/vendor/magento/framework/Interception/Interceptor.php(142): Magento\PageCache\Model\App\FrontController\BuiltinPlugin->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#39 /data/web/magento2/var/generation/Magento/Framework/App/FrontController/Interceptor.php(26): Magento\Framework\App\FrontController\Interceptor->___callPlugins('dispatch', Array, Array)
#40 /data/web/magento2/vendor/magento/framework/App/Http.php(135): Magento\Framework\App\FrontController\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#41 /data/web/magento2/vendor/magento/framework/App/Bootstrap.php(258): Magento\Framework\App\Http->launch()
#42 /data/web/magento2/pub/index.php(37): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http))
#43 {main}";s:3:"url";s:32:"/review/product/listAjax/id/3019";s:11:"script_name";s:10:"/index.php";}a

Normally a customer won't see this, but a search on Google says otherwise:
https://www.google.nl/search?q=503+product/listAjax/id
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 10, 2018
@magento-engcom-team
Copy link
Contributor

@ruthger92, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Feb 14, 2018
@ananth-iyer
Copy link
Member

I'm working on it #dmcdindia

@magento-engcom-team
Copy link
Contributor

@Ananth747 thank you for joining. Please accept team invitation here and self-assign the issue.

@ananth-iyer ananth-iyer self-assigned this May 19, 2018
ananth-iyer added a commit to ananth-iyer/magento2 that referenced this issue May 19, 2018
@ananth-iyer
Fixed review list ajax if product not exist redirect to 404 page mage…
a1d0e3b 
…nto#13102
@ananth-iyer ananth-iyer mentioned this issue May 19, 2018
Merged
4 tasks
@ananth-iyer ananth-iyer mentioned this issue May 19, 2018
Merged
4 tasks
@ananth-iyer ananth-iyer added the Progress: PR Created Indicates that Pull Request has been created to fix issue label May 19, 2018
ananth-iyer added a commit to ananth-iyer/magento2 that referenced this issue May 21, 2018
@ananth-iyer
Fixed review list ajax if product not exist redirect to 404 page mage…
b81bf67 
…nto#13102 #2
@ananth-iyer
Copy link
Member

@magento-engcom-team When my pull request will be merged?

@ishakhsuvarov
Copy link
Contributor

@Ananth747 Unfortunately, there is no exact estimate.

@magento-engcom-team
Copy link
Contributor

Hi @ruthger92. Thank you for your report.
The issue has been fixed in #15369 by @Ananth747 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.7 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Aug 14, 2018
magento-engcom-team added a commit that referenced this issue Aug 14, 2018
@magento-engcom-team
ENGCOM-2720: Fixed review list ajax if product not exist redirect to …
38f7daa 
…404 page #13102 #15369

 - Merge Pull Request #15369 from Ananth747/magento2:Ananth747-patch-1
 - Merged commits:
   1. a1d0e3b
   2. b81bf67
   3. b0848c4
   4. f5bd1c6
magento-engcom-team pushed a commit that referenced this issue Aug 14, 2018
ENGCOM-2720: Fixed review list ajax if product not exist redirect to …
12ff548 
…404 page #13102 #15369
@mage2pratik mage2pratik mentioned this issue Aug 15, 2018
Merged
4 tasks
@sidolov
Copy link
Contributor

sidolov commented Aug 16, 2018

Hi @ruthger92. Thank you for your report.
The issue has been fixed in #17632 by @mage2pratik in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.16 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Aug 16, 2018
magento-engcom-team added a commit that referenced this issue Aug 16, 2018
@magento-engcom-team
ENGCOM-2806: [Backport] Fixed review list ajax if product not exist r…
a1bb56e 
…edirect to 404 page #13102 #17632

 - Merge Pull Request #17632 from mage2pratik/magento2:2.1-develop-PR-port-15369
 - Merged commits:
   1. 81c0320
   2. c729a3b
   3. 53ba0ac
   4. 01a7e20
magento-engcom-team pushed a commit that referenced this issue Aug 16, 2018
ENGCOM-2806: [Backport] Fixed review list ajax if product not exist r…
5483ecf 
…edirect to 404 page #13102 #17632
@nmalevanec nmalevanec mentioned this issue Aug 21, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @ruthger92. Thank you for your report.
The issue has been fixed in #17721 by @nmalevanec in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananth-iyer ananth-iyer

Labels
Event: dmcdindia Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ishakhsuvarov @sidolov @ruthgeridema @ananth-iyer @magento-engcom-team