Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDVA-275 code is not present in Magento 2.1-develop - 2.3-develop #13120

Closed
AntonEvers opened this issue Jan 11, 2018 · 4 comments
Closed

MDVA-275 code is not present in Magento 2.1-develop - 2.3-develop #13120

AntonEvers opened this issue Jan 11, 2018 · 4 comments
Labels
Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@AntonEvers
Copy link
Contributor

Emails from admin being sent out using default config’s email, not the specific store email

Preconditions

  1. 2.1-develop
  2. 2.2-develop
  3. 2.3-develop

Steps to reproduce

  1. Set store's email addresses different on store level than on default level
  2. Send a credit memo email or re-send an order email

Expected result

  1. From email address is the address that is configured in the store from which the order is placed

Actual result

  1. From email address is the address that is configured in the default config

9fc059b did not make it to the 2.1+ branches. It is only present in branch 2.0.

@orlangur
Copy link
Contributor

Oh, nice finding 👍 Wondering if we can analyze git log automatically/semiautomatically to find all missing fixes.

AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Jan 14, 2018
AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Jan 14, 2018
AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Jan 14, 2018
@magento-engcom-team
Copy link
Contributor

@ajpevers, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Jan 22, 2018
@engcom-Bravo engcom-Bravo self-assigned this Dec 30, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 30, 2019

Hi @engcom-Bravo. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@engcom-Bravo engcom-Bravo removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 30, 2019
@engcom-Bravo
Copy link
Contributor

Hello @AntonEvers
On Magento 2.4-develop, the Credit Memo email sender is the email
custom_email_store
Here is a screenshot from the mail client where you can see that the mail sender is the one configured in Store view
credit_memo_email1

So, we have to close it.
Please feel free to comment, reopen or create new ticket according to the Issue reporting guidelines .
Thank you for collaboration.

@engcom-Bravo engcom-Bravo added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Dec 30, 2019
@engcom-Bravo engcom-Bravo removed their assignment Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants