Skip to content

Issue in language translation #13599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Asifjalil99 opened this issue Feb 10, 2018 · 10 comments
Closed

Issue in language translation #13599

Asifjalil99 opened this issue Feb 10, 2018 · 10 comments
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed

Comments

@Asifjalil99
Copy link

i am trying to translate magento 2.2 to other languages in magento, all the steps are working fine and translate correctly but few minor changes did not change, I need your help friends.

when i try to translate the popup Newsletter heading its not translating to any language while other things are changed in popup box (the news letter comes from text box of magento admin panel).

close button on news letter popup needs to change.

when 1 item in cart are added its not translating but when 2 items or more are added its translated.

delete item in cart is translated while edit item in cart is not translated.

need to translate All Category headings some of my coding is also attached please check and give me a idea is there anything wrong in the code? thanks

category and cart picture
popup changes
code

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Feb 10, 2018
@Asifjalil99
Copy link
Author

any one please urgent help need .. :(

@orlangur
Copy link
Contributor

#13528 may be helpful in your case.

@Asifjalil99
Copy link
Author

@orlangur i already check this but what the meaning of this point.
"Clean Magento installation with a translation file translating the string "Item in Cart" from Magento_Checkout."

@orlangur
Copy link
Contributor

@Asifjalil99 it means literally what you already have in description of this issue: there is a custom translation for "Item in Cart", in your case "test item".

So, to summarize, there could still be some places in Magento which are not translatable, you need to check 2.2-develop to find out whether particular place is already fixed and then backport, if there is still no fix, you need to debug and fix such place by yourself (ideally, providing a PR to this repo so that everybody benefits from it).

@Asifjalil99
Copy link
Author

@orlangur thanks for your support i already fix it by my self the problem is coming from js-translation.josn file once again thanks for the support. :)

@orlangur
Copy link
Contributor

@Asifjalil99 please correct if I'm wrong, it looks like #13471 + #13528 should fix the issue you mentioned completely.

I propose to close this issue for now and reopen it in case additional non-translatable cases will be found.

@Asifjalil99
Copy link
Author

My issue is not related to like #13471 + #13528 , i just simple add "Item in Cart" in js-translation.josn file manually and its work for me you can close this issue
Thanks for your support.

@orlangur
Copy link
Contributor

Thanks!

simple add "Item in Cart" in js-translation.josn file manually and its work for me

Yeah, and those issues are about such phrase pickep up correctly by phrase collector.

@Asifjalil99
Copy link
Author

yeah i see lot of people face this kind of issue and i will do another post with full method soon so the issue will be solve :)

@atolodas
Copy link

Work for me:
Add to: /vendor/magento/module-translation/etc/di.xml
in line ~ 68
<item name="translate_args" xsi:type="string"><![CDATA[~translate args\=("|'|"')([^\'].*?)('"|'|")~]]></item>

Then empty the pub/static/frontend folder and run
and if lang LT
php bin/magento setup:upgrade; php bin/magento setup:di:compile; php bin/magento setup:static-content:deploy lt_LT; php bin/magento cache:flush;

Demo: https://mg2.bandom.info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed
Projects
None yet
Development

No branches or pull requests

4 participants