Incompatibilies with jQuery 3 #13685

kirmorozov · 2018-02-15T20:31:08Z

We'd like to use tools that are standard in web development industry.
This includes latest jQuery.

Preconditions

I use Bootstrap 4
I want to use navigation and other scripts.

Steps to reproduce

npm install jquery
Copy jquery.js to you your theme
Build theme.
Open product page with configurable product.

Expected result

No errors

Actual result

size() is not defined (http://api.jquery.com/size/ was deleted from jQuery 3)

…ll with on('load') as of https://jquery.com/upgrade-guide/3.0/#breaking-change-load-unload-and-error-removed

magento-engcom-team · 2018-02-16T09:30:05Z

@kirmorozov, thank you for your report.
We've acknowledged the issue and added to our backlog.

orlangur · 2018-02-16T13:03:14Z

Such bug report is not valid. While jQuery, like any other third party library, can definitely be upgraded via one or more PRs, core is not supposed to be forward compatible with any version but only with ones actually used.

… with jQuery 3.* #13686 - Merge Pull Request #13686 from kirmorozov/magento2:2.3-develop-13685 - Merged commits: 1. 52875a8

… with jQuery 3.* #13686

@nmalevanec

Accepted Public Pull Requests: - #13735: [Forwardport] Fix adding values to system variable collection (by @nmalevanec) - #13733: [Forwardport] Refactoring: remove unuseful temporary variable (by @nmalevanec) - #13731: [Forwardport] Display a more meaningful error message in case of misspelt module name (by @nmalevanec) - #13727: [Forwardport] Show maintenance IP-address without commas (by @nmalevanec) - #13729: [Forwardport] Update StorageInterface.php (by @nmalevanec) - #13635: [Forwardport] #13498 issue #13497 - Method getUrl in Magento\Catalog\Model\Product\Attribute\Frontend\Image (by @nmalevanec) - #13686: #13685: Replaced .size() with .length to be compatible with jQuery 3.* (by @kirmorozov) - magento-engcom/magento2ce#1203: Report error csv doesn't work when trying to import a csv file with semicolon delimiter[forwardport]. (by @nmalevanec) - #13361: Fix URL passed to static.php in PHP in-development server (by @nieltg) Fixed GitHub Issues: - #5015: Report error csv doesn't work when trying to import a csv file with semicolon delimiter (reported by @agoeurysky) has been fixed in magento-engcom/magento2ce#1203 by @nmalevanec in 2.3-develop branch Related commits: 1. 7c03614

magento-engcom-team · 2018-03-17T10:20:13Z

Hi @kirmorozov. Thank you for your report.
The issue has been fixed in #13688 by @kirmorozov in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

…ith jQuery 3.x #13688 - Merge Pull Request #13688 from kirmorozov/magento2:2.3-develop-13685-jquery-mobile - Merged commits: 1. c36fb76 2. b21f2a6

…ith jQuery 3.x #13688

* Updating jQuery to 3.3.1 (originally from npm) * Updating jQuery Migrate 3.0.1 (originally from npm)

kirmorozov · 2018-04-05T10:53:13Z

Main concern was .browser from #14267
Its resolved.

DanielRuf · 2018-05-31T15:59:57Z

Sure.

Just to mention it

It was just meant as notice.

DanielRuf · 2018-05-31T16:00:25Z

This upgrade would be very useful if it can be included in the next major release.

Totally agree with this.

kirmorozov · 2018-05-31T17:07:59Z

@VladimirZaets was assigned to latest PR,
There might be 3-4-5 other issues found after complete MFTF run, can be resolved easily.

zetlen · 2018-06-21T16:35:28Z

If jQuery can be upgraded to the 3.x release stream without significant regression, then we could do it. But we can't set a precedent where we keep all of the core lib/ support libraries up to date. A lot of working software may be reliant on behaviors that are peculiar to those versions. Semantic versioning can only protect us so much from this.

I sympathize with @leoquijano in being forced to use older versions of plugins, but the jQuery install base is still largely 1.x, and so the community of plugin authors usually do maintain 1.x compatibility. Alternatives are likely to exist.

So again, in the individual case, I support experimenting with jQuery 3, but I think it's likely that an upgrade would break more functionality than it would enable.

leoquijano · 2018-06-21T20:56:51Z

@zetlen, I would be more concerned about what jQuery version is expected by the other libraries, and not by the global use base. If we were concerned by that metric, we wouldn't be using PHP 7 either, since 82.7% of the global installations use v5.x.

Since jQuery is such a critical library, having an old version of it is probably blocking upgrades for the other libraries, and not the other way around. Keep in mind that a jQuery Migrate v3 plugin is available to smooth out the upgrade process. That effectively makes it look like we have v1.12 in terms of backwards compatibility.

zetlen · 2018-07-04T16:08:26Z

@leoquijano We're not officially refusing a jQuery 3 upgrade because of that install base metric. It's just a stat to help us all weigh the costs and benefits.

Again, we're open to a PR to upgrade to jQuery 3, considering its special role as a nearly global dependency. But I want to avoid:

Unforeseen regressions in popular third party modules
A combination of modules that loads jQuery 3 and jQuery 1.12 at the same time

We all probably want such a PR to have safeguards in place to prevent that last thing in particular. Maybe \Magento\Framework\RequireJs could have a server-side sanity check in place to check for multiple jQuery versions.

leoquijano · 2018-07-04T21:08:50Z

Thanks @zetlen. There are a few PRs already in progress, if I understand correctly?

zetlen · 2018-07-05T16:19:10Z

That's right! I'm just stating on this thread our requirements for such a PR to merge. Thanks!

piotrekkaminski · 2018-08-14T22:08:01Z

@zetlen any update on this one? It is too risky to get into a patch release but it would be super helpful for 2.4 branch as it helps us address major security questions.

zetlen · 2018-08-15T06:03:18Z

@piotrekkaminski Nobody has sent me a jQuery upgrade PR to review, but I also haven't looked for one. The things we are looking for are still the same:

an upgrade to current-state jQuery 3
"Migration" plugins as necessary to cover breaking changes
Refactoring where any regressions occur
No visible test regression
Some kind of safeguard to prevent a downstream theme from loading more than one jQuery version at once

I would be really excited to see such a change, and though there is a regression risk, I think it's digestible by an ambitious community developer.

piotrekkaminski · 2018-08-15T13:22:38Z

@zetlen so this PR only solves your first point not the others, right? #15531

zetlen · 2018-08-15T15:58:34Z

@piotrekkaminski It may satisfy the following, too:

Refactoring where any regressions occur
No visible test regression

But without seeing the output of an end to end test, we can't be sure!

kirmorozov · 2018-08-22T13:34:12Z

@piotrekkaminski Hello old friend.
This initiative is there since April and I have jQuery 3 in production for front-end.
Its been few months since I put a bit of an effort to fix tests and minor core incompatibilities.
Everything else was pushed to the core before April.

kirmorozov · 2018-09-24T15:47:38Z

@piotrekkaminski
When do you expect to have end-to-end tests?
I expect to put it in production as early as Magento 2.3 Production release.

Revert "MAGETWO-95280: Storefront Images Don't Scale Back To Original Size In Mobile" This reverts commit 13d360d

ghost · 2018-11-30T09:05:20Z

Hi @kirmorozov, thank you for you report, this issue has already fixed in 2.3-develop branch, and available on 2.3.0 release.

orlangur · 2018-11-30T15:03:59Z

@engcom-backlog-nazar are you sure? https://github.com/magento/magento2/blob/2.3-develop/lib/web/jquery.js#L2

ghost · 2018-11-30T15:15:51Z

@orlangur hmm.., but this comment -> #13685 (comment)

…uery Migrate from online builder

Fixing tabs behaviour with upgraded jquery-ui in admin.

Erfans · 2019-10-02T07:38:57Z

is there any update? since the the jQuery version is still v1.12.4 https://github.com/magento/magento2/blob/2.3.2/lib/web/jquery.js#L2

kirmorozov self-assigned this Feb 15, 2018

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 15, 2018

kirmorozov mentioned this issue Feb 15, 2018

#13685: Replaced .size() with .length to be compatible with jQuery 3.* #13686

Merged

4 tasks

kirmorozov added a commit to kirmorozov/magento2 that referenced this issue Feb 16, 2018

magento#13685: Upgraded jquery.mobile.custom to 1.5.0-alpha.1

c36fb76

kirmorozov mentioned this issue Feb 16, 2018

#13685 Upgrade jquery.mobile.custom.js to be compatible with jQuery 3.x #13688

Merged

4 tasks

kirmorozov added a commit to kirmorozov/magento2 that referenced this issue Feb 16, 2018

magento#13685: Fixed compatibility with jQuery 3.x replaced load() ca…

b21f2a6

…ll with on('load') as of https://jquery.com/upgrade-guide/3.0/#breaking-change-load-unload-and-error-removed

magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Feb 16, 2018

magento-engcom-team pushed a commit that referenced this issue Feb 21, 2018

#13685: Replaced .size() with .length to be compatible with jQuery 3.*

52875a8

magento-engcom-team added a commit that referenced this issue Feb 21, 2018

MAGETWO-87935: #13685: Replaced .size() with .length to be compatible…

59d3e60

… with jQuery 3.* #13686 - Merge Pull Request #13686 from kirmorozov/magento2:2.3-develop-13685 - Merged commits: 1. 52875a8

magento-engcom-team pushed a commit that referenced this issue Feb 21, 2018

MAGETWO-87935: #13685: Replaced .size() with .length to be compatible…

f23aef3

… with jQuery 3.* #13686

magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 22, 2018

magento-engcom-team pushed a commit that referenced this issue Mar 17, 2018

ENGCOM-774: #13685 Upgrade jquery.mobile.custom.js to be compatible w…

4033aae

…ith jQuery 3.x #13688

kirmorozov added a commit to kirmorozov/magento2 that referenced this issue Apr 5, 2018

magento#13685:

bcdff33

* Updating jQuery to 3.3.1 (originally from npm) * Updating jQuery Migrate 3.0.1 (originally from npm)

kirmorozov mentioned this issue Apr 5, 2018

#13685: Upgrading jQuery to 3.3.1 #14556

Closed

4 tasks

kirmorozov mentioned this issue Aug 13, 2018

jquery PCI Compliance vulnerability CVE-2015-9251 #15156

Closed

kirmorozov added a commit to kirmorozov/magento2 that referenced this issue Nov 28, 2018

magento#13685: Returned jquery Mobile 1.5.0-alpha.1

430ccdc

Revert "MAGETWO-95280: Storefront Images Don't Scale Back To Original Size In Mobile" This reverts commit 13d360d

ghost closed this as completed Nov 30, 2018

kirmorozov added a commit to morozov-group/magento2-edge that referenced this issue Mar 3, 2019

magento#13685: * Updating jQuery, jQuery UI (originally from npm), jQ…

fc47098

…uery Migrate from online builder

kirmorozov added a commit to morozov-group/magento2-edge that referenced this issue Mar 26, 2019

magento#13685: Patch up tabs.js

b427e8b

kirmorozov added a commit to morozov-group/magento2-edge that referenced this issue Mar 26, 2019

magento#13685: * Updating jQuery, jQuery UI (originally from npm), jQ…

39b3f30

…uery Migrate from online builder

kirmorozov added a commit to morozov-group/magento2-edge that referenced this issue Apr 10, 2019

magento#13685:

d2b92d6

Fixing tabs behaviour with upgraded jquery-ui in admin.

kirmorozov added a commit to morozov-group/magento2-edge that referenced this issue May 30, 2019

magento#13685: Upgrade jQuery to 3.4.1

44fafef

kirmorozov added a commit to morozov-group/magento2-edge that referenced this issue May 30, 2019

magento#13685: Upgrade jQuery.min to 3.4.1

f810f31

leoquijano mentioned this issue Aug 20, 2020

Remove jQuery Migrate #25847

Closed

4 tasks

kirmorozov mentioned this issue Mar 18, 2023

Upgrade jquery to 3.6.0 #34162

Closed

5 tasks

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Incompatibilies with jQuery 3 #13685

Incompatibilies with jQuery 3 #13685

kirmorozov commented Feb 15, 2018

magento-engcom-team commented Feb 16, 2018

orlangur commented Feb 16, 2018

magento-engcom-team commented Mar 17, 2018

kirmorozov commented Apr 5, 2018

DanielRuf commented May 31, 2018

DanielRuf commented May 31, 2018

kirmorozov commented May 31, 2018

zetlen commented Jun 21, 2018

leoquijano commented Jun 21, 2018 •

edited

Loading

zetlen commented Jul 4, 2018

leoquijano commented Jul 4, 2018

zetlen commented Jul 5, 2018

piotrekkaminski commented Aug 14, 2018

zetlen commented Aug 15, 2018

piotrekkaminski commented Aug 15, 2018

zetlen commented Aug 15, 2018

kirmorozov commented Aug 22, 2018

kirmorozov commented Sep 24, 2018

ghost commented Nov 30, 2018

orlangur commented Nov 30, 2018

ghost commented Nov 30, 2018

Erfans commented Oct 2, 2019

Incompatibilies with jQuery 3 #13685

Incompatibilies with jQuery 3 #13685

Comments

kirmorozov commented Feb 15, 2018

Preconditions

Steps to reproduce

Expected result

Actual result

magento-engcom-team commented Feb 16, 2018

orlangur commented Feb 16, 2018

magento-engcom-team commented Mar 17, 2018

kirmorozov commented Apr 5, 2018

DanielRuf commented May 31, 2018

DanielRuf commented May 31, 2018

kirmorozov commented May 31, 2018

zetlen commented Jun 21, 2018

leoquijano commented Jun 21, 2018 • edited Loading

zetlen commented Jul 4, 2018

leoquijano commented Jul 4, 2018

zetlen commented Jul 5, 2018

piotrekkaminski commented Aug 14, 2018

zetlen commented Aug 15, 2018

piotrekkaminski commented Aug 15, 2018

zetlen commented Aug 15, 2018

kirmorozov commented Aug 22, 2018

kirmorozov commented Sep 24, 2018

ghost commented Nov 30, 2018

orlangur commented Nov 30, 2018

ghost commented Nov 30, 2018

Erfans commented Oct 2, 2019

leoquijano commented Jun 21, 2018 •

edited

Loading