Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In payment step of checkout I cannot unselect #billing-save-in-address-book checkbox in non-first payment method #13692

Closed
ghost opened this issue Feb 16, 2018 · 7 comments
Closed

In payment step of checkout I cannot unselect #billing-save-in-address-book checkbox in non-first payment method #13692

ghost opened this issue Feb 16, 2018 · 7 comments
Assignees
@rakesh-gangani
Labels
Event: dmcdindia Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@ghost
Copy link

ghost commented Feb 16, 2018

Preconditions

  1. Magento version 2.2.0
  2. At least 2 payments methods enabled

Steps to reproduce

  1. Log in to your client account.
  2. Add product to cart.
  3. Go to checkout and click next button to be able to choose payment methods.
  4. Open payment method other than the first one.
  5. Uncheck My billing and shipping address are the same checkbox
  6. Choose New address on the billing address dropdown
  7. Fill address
  8. Click on label Save in address book

Expected result

  1. The checkbox is unchecked.

Actual result

  1. The checkbox stays checked regardless click on label

That happens because in every payment method tab Save in address book checkbox has the same id: #billing-save-in-address-book If there are multiple checkboxes with the same id all labels are associated with the first one.
zrzut ekranu 2018-02-16 o 10 30 26
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 16, 2018
@magento-engcom-team
Copy link
Contributor

@NeosKnowledgeBasePluswerk, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Feb 22, 2018
@magento-engcom-team
Copy link
Contributor

@NeosKnowledgeBasePluswerk, thank you for your report.
We've acknowledged the issue and added to our backlog.

@rakesh-gangani
Copy link
Contributor

#DMCDINDIA

@magento-engcom-team
Copy link
Contributor

@rsquarem thank you for joining. Please accept team invitation here and self-assign the issue.

@rakesh-gangani rakesh-gangani self-assigned this May 19, 2018
@rakesh-gangani rakesh-gangani mentioned this issue May 19, 2018
Merged
4 tasks
@magento-engcom-team magento-engcom-team added the Progress: PR Created Indicates that Pull Request has been created to fix issue label May 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @NeosKnowledgeBasePluswerk. Thank you for your report.
The issue has been fixed in #15344 by @rakesh-gangani in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 15, 2018
@rakesh-gangani rakesh-gangani mentioned this issue Jun 15, 2018
Open
4 tasks
@mage2pratik mage2pratik mentioned this issue Jul 14, 2018
Merged
4 tasks
@sidolov
Copy link
Contributor

sidolov commented Jul 19, 2018

Hi @NeosKnowledgeBasePluswerk. Thank you for your report.
The issue has been fixed in #16811 by @mage2pratik in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jul 19, 2018
@ihor-sviziev ihor-sviziev mentioned this issue Jul 22, 2018
Merged
4 tasks
@sidolov
Copy link
Contributor

sidolov commented Jul 24, 2018

Hi @NeosKnowledgeBasePluswerk. Thank you for your report.
The issue has been fixed in #16993 by @ihor-sviziev in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakesh-gangani rakesh-gangani

Labels
Event: dmcdindia Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rakesh-gangani @sidolov @magento-engcom-team