-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magento 2 Bin directory #1429
Comments
@jamescowie , we're currently working on this fix (MAGETWO-38518) and you described exactly what we're going to change. So, I believe, we should cover the case you describe. |
Also looks like we have reported duplicate issue #1351 |
Hi @vancoz yep this is a reported issue of the other ticket I raised. Happy to close this or the other. Reason for a new ticket was to provide more info on a single issue that was not git workflow :) While continuing my work on M2 and related to this issue one really annoying thing other than getting my bin dir wiped out each update is that it seems that the permissions for |
@jamescowie thank you for detailed description, bug already fixed and right now we are working on contribution. Regarding question about permissions - it is not intentional. |
It should not be replaced anymore so closing for now. |
So magento now has a
bin
directory where the new and greatmagento
command can be found.However it is a common configuration option for projects to also use
bin
for composer binaries that are available. E.g.Behat, PHPSpec, PHPUnit
etc.Because in the package
magento2-base
there is the mapping information for:When the composer and the hackathon installer process run after an update / install then the project roots
bin
directory is cleared out and only the magento 2 directory is created. This causes problems for projects that are configured to run the binaries from./bin
. Granted the binaries are still available from./vendor/package/bin/package
however it would be ideal to remove the mapping frommagento2-base
and replace with the following configuration in composer.json"bin": ["bin/magento”]
This would mean that composer can place the
magento
command into the projects configured bin directory offering a single configuration node for thebin
folder that is managed viacomposer
andmagento
What do you think ?
This relates to MAGETWO-38518 and #1351 but contains more information on what is causing the replacement.
The text was updated successfully, but these errors were encountered: