Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraneous margins on product list and product list items #15308

Closed
DanielRuf opened this issue May 18, 2018 · 3 comments
Closed

extraneous margins on product list and product list items #15308

DanielRuf opened this issue May 18, 2018 · 3 comments
Assignees
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Release Line: 2.2

Comments

@DanielRuf
Copy link
Contributor

DanielRuf commented May 18, 2018

Preconditions

  1. Magento 2.2.4

Steps to reproduce

  1. open list view of products on a page
  2. inspect the list .column.main .product-items and one product .products-list .product-item

Expected result

  1. there should not be any extraneous styles

Actual result

  1. there are negative and positive margins which do nothing combined

The following code would remove it:

.products-list .product-item {
    padding-left: 0;
  }
  .column.main .product-items {
    margin-left: 0;
  }

In general I see no sense in these margins and paddings.

See

.column.main {
.product {
&-items {
margin-left: -@indent__base;
}
&-item {
padding-left: @indent__base;
}
}
}

https://github.com/magento/magento2/blame/c0123f3bcaf3b3878b9b6e425f92f16468aaf87c/app/design/frontend/Magento/luma/Magento_Catalog/web/css/source/module/_listings.less#L167-L177

08b6a7f

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 18, 2018
@StevenGuapaBV StevenGuapaBV self-assigned this Jun 7, 2018
StevenGuapaBV added a commit to StevenGuapaBV/magento2 that referenced this issue Jun 7, 2018
removed extraneous margin and compensated padding and set both to 0, which creates the same effect
@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your report.
The issue has been fixed in #15936 by @StevenGuapaBV in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 13, 2018
magento-engcom-team added a commit that referenced this issue Jun 13, 2018
 - Merge Pull Request #15936 from StevenGuapaBV/magento2:2.2-develop
 - Merged commits:
   1. cae12b1
@VladimirZaets
Copy link
Contributor

Hi @DanielRuf. Thank you for your report.
The issue has been fixed in #15975 by @chirag-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@VladimirZaets VladimirZaets added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 18, 2018
magento-engcom-team added a commit that referenced this issue Jun 18, 2018
 - Merge Pull Request #15975 from chirag-wagento/magento2:2.3-develop-PR-port-15936
 - Merged commits:
   1. eee2e7c
gelanivishal pushed a commit to gelanivishal/magento2 that referenced this issue Aug 6, 2018
removed extraneous margin and compensated padding and set both to 0, which creates the same effect
@sidolov
Copy link
Contributor

sidolov commented Aug 6, 2018

Hi @DanielRuf. Thank you for your report.
The issue has been fixed in #17379 by @gelanivishal in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Aug 6, 2018
magento-engcom-team added a commit that referenced this issue Aug 6, 2018
 - Merge Pull Request #17379 from gelanivishal/magento2:2.1-develop-PR-port-15936
 - Merged commits:
   1. ebdc7c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Release Line: 2.2
Projects
None yet
Development

No branches or pull requests

5 participants