Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a serious debug toolbar #1554

Closed
sedax90 opened this issue Jul 24, 2015 · 11 comments
Closed

Implement a serious debug toolbar #1554

sedax90 opened this issue Jul 24, 2015 · 11 comments
Assignees

Comments

@sedax90
Copy link

sedax90 commented Jul 24, 2015

Having a good debugging tool it is fundamental for a good project development. Currently the best tool of all pph framework is definitely the debug toolbar Symfony2.
It would be nice to have a tool with similar functionality already built into Magento, would greatly simplify the work to each developer.

screen shot 2012-04-13 at 4 39 20 pm

@mzeis
Copy link
Contributor

mzeis commented Aug 2, 2015

This would definitely by a good addition.

@Flyingmana
Copy link
Member

I would vote for using the symfony (or zend, I think they have one, too) toolbar as base

@alankent
Copy link

alankent commented Aug 2, 2015

Z-Ray has a Magento 1 toolbar and will probably have a Magento 2 toolbar too. I am wondering whether this is best done as an extension? What is reason for making part of core? Or a hackathon project? (Curious to hear different opinions.)

@mzeis
Copy link
Contributor

mzeis commented Aug 2, 2015

If I remember correctly, you only get Z-Ray with Zend Server, right? That would rule it out for us pretty much.

In my opinion it should be part of the core to support integrators (dev toolbars can speed up development quite a bit because you don't have to insert debug code / trace for the same reasons again and again).

If there will not be a developer toolbar in the core, for sure there will be several implementations by the community again. I'd like to see a joined effort, be it inside or outside the core.

@sedax90
Copy link
Author

sedax90 commented Aug 3, 2015

Drupal 8 has a module who integrate perfectly Symfony2 profiler (https://www.drupal.org/project/webprofiler). I do not think it's too expensive to incorporate in magento if we think of the enormous benefits that would bring.

@alankent
Copy link

alankent commented Aug 3, 2015

An interesting question to me is whether "we" need to do a better job to coordinate larger community projects vs just wait for the core team to get to it. Peripheral projects like this feel more community friendly. How many community members would be be interested in helping this one? Is the job then more to work out a framework to help community members to collaborate? Eg define some best practices for teams to work together (working groups). To me this clearly should be a separate module so it's optional, but it makes sense having just one with lots of people contributing.

For example, we set up a list of "community projects" in a wiki page or something, then get a Magento engineer to be the bridge between core development and each such project, a community lead on the project and a list of volunteers. (I am sure we can borrow a process from some other project.)

@wojtekn
Copy link
Contributor

wojtekn commented Aug 4, 2015

If you decide to include toolbar in core, maybe just build a base which provides foundation. Then extension developers could extend it and add new toolbar features. Core toolbar could include debug features which already exist in core (enabling/disabling profiler, hints, inline translation, displaying profiler output etc.) and more could be added by community.

@roman204
Copy link

roman204 commented Aug 6, 2015

Good idea @wojtekn, and are the core developers not also missing such a feature ? So many things in Magento2 are inspired by the community... but a "core" developer toolbar not :-(

@vpietri
Copy link

vpietri commented Dec 4, 2015

In order to discover Magento2 I've made a simple developer toolbar https://github.com/vpietri/magento2-developer-quickdevbar . Let me know how can I improve it.

@pboisvert
Copy link

@piotrekkaminski Piotr can you take this one for dev experience?

@piotrekkaminski
Copy link
Contributor

This is not currently a priority since external projects exist that seems to be tackling this issue:

magento-team pushed a commit that referenced this issue Oct 5, 2017
[EngCom] Public Pull Requests - develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants