Need information about translating issue (Magento Swatches Js)

[Amadeco]

Preconditions

1. Magento 2.2.4
2. PHP 7.1.17-1 & MySQL 5.7.22

Steps to reproduce

1. You need a Configurable Product with a Swatch Product Attribute in Attribute Set
2. Swatch attribute have color or image attached to each swatch attribute value
3. This Parent Product have more than three children configured with the Swatch Attribute
4. In configuration, you need to have in Catalog > Storefront > Swatches per Product defined to 2
5. In configuration, you need to have in Catalog > Storefront > Show Swatches in Product List defined to Yes

Expected result

**String can be translated through i18n string in dictonary.csv**

Actual result

**String is not translated**

---

I would like to have some information about this line :

magento2/app/code/Magento/Swatches/view/frontend/web/js/swatch-renderer.js

Line 503 in 38d7977

html += '<a href="#" class="' + moreClass + '">' + moreText + '</a>';

Indeed, I do not see any process to translate this string apart to pass a new value to options moreButtonText.

However, you pass the mage/translate to the define module, so a simple :
html += '<a href="#" class="' + moreClass + '">' + $t(moreText) + '</a>';
would be enough.

Could you provide me some information about this line, or we need to create a pull request about it.

Thank you,

Ilan PARMENTIER

[magento-engcom-team]

Hi @mageho. Thank you for your report.
The issue has been fixed in #16190 by @Karlasa in 2.2-develop branch
Related commit(s):

• d468dba73f952522f3c6f9bca074c1a591562ca0

The fix will be available with the upcoming 2.2.6 release.

[sidolov]

Hi @mageho. Thank you for your report.
The issue has been fixed in #16229 by @Karlasa in 2.1-develop branch
Related commit(s):

• d09dbe43f20e8a1ef8b943a6d4db181d780860df
• f5230328a387adb4c5c4bf454802b7cd3f12ea0f

The fix will be available with the upcoming 2.1.15 release.

[magento-engcom-team]

Hi @mageho. Thank you for your report.
The issue has been fixed in #16228 by @Karlasa in 2.3-develop branch
Related commit(s):

• abcded5aee17b30b3eb5b5da98c67e9bba79858f
• 988ef8956d03341280f3599ffb3bb5049cd4af56

The fix will be available with the upcoming 2.3.0 release.

[menphis89]

Hi, I looked carefully if it was all correct in my magento as you describe in the following interventions and it is! Except that it doesn't translate this thing troubles me, the More button I can't translate it in any way...
i have magento:
Magento 2.3.0
PHP 7.1
MySQL 5.7

in the file: /vendor/magento/module-swatches/view/frontend/web/js/swatch-renderer.js
moreButtonText: $t('More'),
then this is correct

the config Swatches is correct like point 4 & 5
In configuration, you need to have in Catalog > Storefront > Swatches per Product defined to 2
In configuration, you need to have in Catalog > Storefront > Show Swatches in Product List defined to Yes

i try whit inline translation, not have option for translate,

same not translate whit i18n ind
/app/i18n/magento2translation/it_IT
"More","Altro"

I could kindly clarify and where am I wrong?
thanks

[Karlasa]

@menphis89
I have M2.3-dev branch
created new conf product
created new it_IT language pack
added phrase into app/i18n/Test/it_IT/it_IT.csv file
run setup:upgrade
changed store language into Italy and cleaned cache
works as expected.