Method $product->getUrlInStore() returning extremely long URLs, could be a bug #16273

adampmoss · 2018-06-20T15:25:48Z

I feel like there may be a bug in the following file because the output of $product->getUrlInStore() is not what I'd expect. Query params related to the store are added to the URL in the following file:

magento2/app/code/Magento/Store/Url/Plugin/RouteParamsResolver.php

Line 66 in 9c14af7

    
           $storeCode = $subject->getScope() ?: $this->storeManager->getStore()->getCode();

By setting an entire object ($subject->getScope()) as the $storeCoderather than just a string default it is causing a very messy looking URL.

Preconditions

Have a Magento installation with more than 1 store
Add store code to URLs in configuration is set to "no"
Magento version 2.2.3

Steps to reproduce

Use the following code where a product model is loaded and where you can see the result:

<?= $product->getUrlInStore() ?>

Expected result

The URL produced for the product would look like:

https://www.domain.com/my-product.html?___store=default

Actual result

The URL produced is actually very long winded:

https://www.domain.com/my-product.html?___store%5B_data%5D%5Bstore_id%5D=1&___store%5B_data%5D%5Bcode%5D=default&___store%5B_data%5D%5Bwebsite_id%5D=1&___store%5B_data%5D%5Bgroup_id%5D=1&___store%5B_data%5D%5Bname%5D=UK+Mainland&___store%5B_data%5D%5Bsort_order%5D=0&___store%5B_data%5D%5Bis_active%5D=1&___store%5B_data%5D%5Bavailable_currency_codes%5D%5B0%5D=GBP&___store%5B_data%5D%5Bbase_currency%5D%5B_data%5D%5Bcurrency_code%5D=GBP&___store%5B_data%5D%5Bcurrent_currency%5D%5B_data%5D%5Bcurrency_code%5D=GBP

The text was updated successfully, but these errors were encountered:

vasilii-b · 2018-06-21T10:44:43Z

This can be reproduced on Magento 2.3-develop as well.
And actually from steps to reproduce there is another bug: Having Add store code to URLs set to NO, still shows you the URL like https://www.domain.com/my-product.html?___store=default.

vasilii-b · 2018-06-21T18:48:13Z

According to the file /app/code/Magento/Store/Url/Plugin/RouteParamsResolver.php and its content, this issue is reproducible on Magento 2.2-develop and Magento 2.1-develop.

# Method $product->getUrlInStore() returning extremely long URLs, could be a bug

# Method $product->getUrlInStore() returning extremely long URLs, could be a bug (cherry picked from commit 7558ac0)

# Method $product->getUrlInStore() returning extremely long URLs, could be a bug

…store-wrong-link_mage22' into magento#16273-product-geturlinstore-wrong-link_mage22

https://github.com/vasilii-b/magento2 into magento#16273-product-geturlinstore-wrong-link_mage22

magento-engcom-team · 2018-07-29T09:08:09Z

Hi @adampmoss. Thank you for your report.
The issue has been fixed in #16468 by @vasilii-b in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

#16468 - Merge Pull Request #16468 from vasilii-b/magento2:#16273-product-geturlinstore-wrong-link_mage22 - Merged commits: 1. 1115b3f 2. 03afbc7 3. 7e3c3fc 4. 66ee827 5. 846f605 6. 65b735b

#16468

sidolov · 2018-08-02T12:05:07Z

Hi @adampmoss. Thank you for your report.
The issue has been fixed in #17261 by @mage2pratik in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

…of product model #17261 - Merge Pull Request #17261 from mage2pratik/magento2:2.3-develop-PR-port-16468 - Merged commits: 1. d116454 2. 3a39a16 3. 16ae409 4. 4dc6aba

…of product model #17261

vasilii-b · 2018-08-02T12:11:30Z

@magento-engcom-team , @sidolov hello!!!
there was already a PR created for 2.3-develop - #16309, earlier than one already merged #17261. 😱 what is going on, guys ? Should we check first if issue/PR already created ? 🤦‍♂️
that is totally unfair...

sidolov · 2018-08-16T13:13:50Z

Hi @adampmoss. Thank you for your report.
The issue has been fixed in #16310 by @vasilii-b in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.16 release.

…product model #16310 - Merge Pull Request #16310 from vasilii-b/magento2:#16273-product-geturlinstore-wrong-link_mage21 - Merged commits: 1. 2f8f469 2. ecfbe24 3. 7833f43 4. 7c33686 5. 726b6e9

…product model #16310

…ong-link_mage21' into 16273-product-geturlinstore-wrong-link_mage21 # Conflicts: # app/code/Magento/Store/Test/Unit/Url/Plugin/RouteParamsResolverTest.php

arion-p · 2019-08-29T08:07:05Z

The issue has been reintroduced in commit 22edbb9. The commit is supposed to revert "Customer related values are NULL for guests" ccba420 but it actually reverts this fix (at least partly)

adampmoss added the bug report label Jun 20, 2018

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jun 20, 2018

vasilii-b added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Jun 21, 2018

vasilii-b self-assigned this Jun 21, 2018

vasilii-b added Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Jun 21, 2018

vasilii-b pushed a commit to vasilii-b/magento2 that referenced this issue Jun 21, 2018

magento#16273: Fix bug in method getUrlInStore() of product model

7558ac0

# Method $product->getUrlInStore() returning extremely long URLs, could be a bug

vasilii-b pushed a commit to vasilii-b/magento2 that referenced this issue Jun 21, 2018

magento#16273: Fix bug in method getUrlInStore() of product model

1115b3f

# Method $product->getUrlInStore() returning extremely long URLs, could be a bug (cherry picked from commit 7558ac0)

vasilii-b pushed a commit to vasilii-b/magento2 that referenced this issue Jun 21, 2018

magento#16273: Fix bug in method getUrlInStore() of product model

2f8f469

# Method $product->getUrlInStore() returning extremely long URLs, could be a bug

This was referenced Jun 21, 2018

#16273: Fix bug in method getUrlInStore() of product model #16308

Closed

#16273: [Forwardport] Fix bug in method getUrlInStore() of product model #16309

Closed

#16273: [Backport] Fix bug in method getUrlInStore() of product model #16310

Merged

vasilii-b pushed a commit to vasilii-b/magento2 that referenced this issue Jun 30, 2018

Merge remote-tracking branch 'upstream/magento#16273-product-geturlin…

03afbc7

…store-wrong-link_mage22' into magento#16273-product-geturlinstore-wrong-link_mage22

vasilii-b mentioned this issue Jun 30, 2018

#16273: Fix bug in method getUrlInStore() of product model #16468

Merged

4 tasks

vasilii-b pushed a commit to vasilii-b/magento2 that referenced this issue Jul 18, 2018

Merge branch 'magento#16273-product-geturlinstore-wrong-link_mage22' of

65b735b

https://github.com/vasilii-b/magento2 into magento#16273-product-geturlinstore-wrong-link_mage22

magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jul 29, 2018

magento-engcom-team closed this as completed Jul 29, 2018

magento-engcom-team pushed a commit that referenced this issue Jul 29, 2018

ENGCOM-2530: #16273: Fix bug in method getUrlInStore() of product model

480b3a1

#16468

mage2pratik mentioned this issue Jul 29, 2018

[Forwardport] #16273: Fix bug in method getUrlInStore() of product model #17261

Merged

4 tasks

sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Aug 2, 2018

magento-engcom-team pushed a commit that referenced this issue Aug 2, 2018

ENGCOM-2606: [Forwardport] #16273: Fix bug in method getUrlInStore() …

fe706c8

…of product model #17261

sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Aug 16, 2018

magento-engcom-team pushed a commit that referenced this issue Aug 16, 2018

ENGCOM-2627: #16273: [Backport] Fix bug in method getUrlInStore() of …

fca327a

…product model #16310

Thundar mentioned this issue Nov 29, 2018

Calling getCurrentUrl on Store will wrongly add "___store" parameter #18941

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Method $product->getUrlInStore() returning extremely long URLs, could be a bug #16273

Method $product->getUrlInStore() returning extremely long URLs, could be a bug #16273

adampmoss commented Jun 20, 2018 •

edited

Loading

vasilii-b commented Jun 21, 2018 •

edited

Loading

vasilii-b commented Jun 21, 2018 •

edited

Loading

magento-engcom-team commented Jul 29, 2018

sidolov commented Aug 2, 2018

vasilii-b commented Aug 2, 2018 •

edited

Loading

sidolov commented Aug 16, 2018

arion-p commented Aug 29, 2019

Method $product->getUrlInStore() returning extremely long URLs, could be a bug #16273

Method $product->getUrlInStore() returning extremely long URLs, could be a bug #16273

Comments

adampmoss commented Jun 20, 2018 • edited Loading

Preconditions

Steps to reproduce

Expected result

Actual result

vasilii-b commented Jun 21, 2018 • edited Loading

vasilii-b commented Jun 21, 2018 • edited Loading

magento-engcom-team commented Jul 29, 2018

sidolov commented Aug 2, 2018

vasilii-b commented Aug 2, 2018 • edited Loading

sidolov commented Aug 16, 2018

arion-p commented Aug 29, 2019

adampmoss commented Jun 20, 2018 •

edited

Loading

vasilii-b commented Jun 21, 2018 •

edited

Loading

vasilii-b commented Jun 21, 2018 •

edited

Loading

vasilii-b commented Aug 2, 2018 •

edited

Loading