Trim whitespace on SKU when saving product

[Zyles]

Preconditions

Magento 2.2

Steps to reproduce

Save or update product in admin with a space at beginning or end.

Expected result

Trim excessive whitespace at beginning and end of SKU

Actual result

Whitespace SKU saved in DB.

The actual problem

When you accidentally save a product with whitespaced SKUs it can become a future problem when syncing data, importing images, or any other process because the SKU was correct but a space was accidentally added.

When doing syncing you could end up with duplicate products with good inventory systems that actually trim the SKU.

The GUI text field itself is padded which can lead to store managers not noticing an accidental extra space.

Is there an applicable real world reason for a space at the beginning of an SKU (and the end)? Why is it allowed?

[magento-engcom-team]

Hi @Zyles. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@Zyles do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[engcom-backlog-nickolas]

Hello @Zyles, thank you for your report.
We've acknowledged the issue and added to our backlog.

[wstnbrg]

#squashtoberfest

[magento-engcom-team]

@wstnbrg thank you for joining. Please accept team invitation here and self-assign the issue.

[wstnbrg]

@magento-engcom-team give me 2.3-develop instance

[magento-engcom-team]

Hi @wstnbrg. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @wstnbrg, here is your Magento instance.
Admin access: https://i-16572-2-3-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[sidolov]

Hi @Zyles. Thank you for your report.
The issue has been fixed in #18019 by @bartoszkubicki in 2.3-develop branch
Related commit(s):

• 6c168dd9ced1f3eb141b01dc8091319b474811a6

The fix will be available with the upcoming 2.3.1 release.

[magento-engcom-team]

Hi @Zyles. Thank you for your report.
The issue has been fixed in #18862 by @gelanivishal in 2.2-develop branch
Related commit(s):

• 109a27eb8bd2e5b8f37fcb84ef4c0d19490a5e16

The fix will be available with the upcoming 2.2.8 release.

[Zyles]

Good, thank you.