complete support for modules outside of app/code/

[Flyingmana]

follow up issue to #1013 this time to make sure everything works, as people reported #1206 is incomplete.
Community driven Issue.

Collects all the seperate Issues and maybe Issues which should be Tested

Issues:

• files in var/generation/ are not generated (solved by add modules outside of app/code directory to DiCompile #1659)
• etc/adminhtml/system.xml is not loaded (probably solved by add support for loading etc/adminhtml/system.xml for modules outside … #1709)

Things which should get tested:

• email templates
• \Magento\Framework\Module\Dir\Reader (loading of composer.json) (maybe solved by Fix issue with ModuleDirReader not finding files in vendor modules #1490 )
• all related to \Magento\Framework\View\Design\Fallback\RulePool
  • email templates
  • dynamic view files
  • template files
  • static view files, such as CSS, JavaScript, images
• DiCompileMultiTenantCommand

Magento Internal parts which may not Work if placed outside of app/code/:

a lot of them make use of $filesystem->getDirectoryRead(DirectoryList::MODULES) where Iam not sure how it works/acts.

• ImportExport
  • \Magento\ImportExport\Controller\Adminhtml\Import\Download
• \Magento\PageCache\Model\Config (reading of vcl file)
• \Magento\Paypal\Block\Iframe
• \Magento\Persistent\Model\Persistent\Config
• DependenciesShowFrameworkCommand
• \Magento\Setup\Model\SampleData

[joshdifabio]

Great job.

See also #1481 and @vrann's update regarding modules in vendor.

[Vinai]

Very cool! I'm sorry I'm on vacation right now and can't check out the branch and play with it. Looking forward to it once I'm back end of August.

[vrann]

• Unit tests run the tests from vendor
• It is possible to locate xsd files to do validation and to reference from xml
• magento2-base component is removed. Project structure should be defined in magento/magento2-community-edition, integration tests, libraries, etc should have own components

[piotrekkaminski]

@buskamuza hey, did the recent changes solved this issue?

[dmitrii-fediuk]

For now a custom extension can reside in the vendor folder but it does not work for translation packages because the system looks for them in app/i18n folder.

[buskamuza]

@dfediuk , could you, please, point to the code that searches in app/i18n? Thanks.

[Flyingmana]

I close this issue, as the basic stuff now works for me