Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for loading etc/adminhtml/system.xml for modules outside … #1709

Closed
wants to merge 1 commit into from

Conversation

Flyingmana
Copy link
Member

…app/code

also likely to solve the problem for other etc files of a module

…app/code

also likely to solve the problem for other etc files of a module
@Flyingmana
Copy link
Member Author

fix for unit and static_annotation Suite will come in a few days.

the others iam currently not sure if broken by me.

a little bit of Feedback about the made change would still be great. Especially if such kind of change has a chance for getting accepted.

@Vinai
Copy link
Contributor

Vinai commented Nov 3, 2015

I think this PR has been made obsolete by the recent updates to the module directory initialization. What do you think @Flyingmana ?

@Flyingmana
Copy link
Member Author

are the changes already in 1.0.0-beta6? If yes I will test it trough.

@Vinai
Copy link
Contributor

Vinai commented Nov 3, 2015

I haven't compared the PR code to the code in the code, but I have used a system.xml file in a module within vendor two weeks ago or so. It just was a very small test file, but it was being parsed. Can you check, too?

@Flyingmana
Copy link
Member Author

My question was not about the code of this PR.
To explain, I dont have much time to maintain multiple dev setups, so I only use the one I work with. This is based on a composer install using the multiple packages on packages.magento.com. I currenlty use 1.0.0-beta6 which has not all latest changes from dev.
I can check it there, but seeing that the xml namespaces still use relative urls, and not the urn:magento:... ones, I expect the result to be negative.

@Vinai
Copy link
Contributor

Vinai commented Nov 4, 2015

Same, so lets wait until release and your dev setup contains the latest changes.

@Flyingmana
Copy link
Member Author

I close this PR, as the change is not needed anymore.
But the Issue is still not completely fixed, it just moved to another place of the framework, which currently only allows modules inside the Project root, not outside of it.

@Flyingmana Flyingmana closed this Nov 8, 2015
magento-team pushed a commit that referenced this pull request Nov 13, 2017
Bug

MAGETWO-70726 [GITHUB] [2.1] Store View Language switch leads to 404 on some cases #5416
MAGETWO-52974 Configurable product options not saved when editing - for mainline
magento-engcom-team added a commit that referenced this pull request Aug 12, 2020
…ags the second time #29424

 - Merge Pull Request #29424 from jmonteros422/magento2-1:1709-modified-date-is-not-updated-when-editing-image-tags-the-second-time
 - Merged commits:
   1. bd364fb
magento-engcom-team pushed a commit that referenced this pull request Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants