Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2 inline edit date issues in admin grid with Ui Component #17564

Closed
Rutvee123 opened this issue Aug 13, 2018 · 9 comments
Closed

Magento 2 inline edit date issues in admin grid with Ui Component #17564

Rutvee123 opened this issue Aug 13, 2018 · 9 comments
Assignees
Labels
Component: Ui Event: mm19in Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Rutvee123
Copy link

Rutvee123 commented Aug 13, 2018

In magento2 Inline Edit date issues while i edit the record it display current date instead of database date

Preconditions

Magento version 2.2.3
php 7.0.29
mysqli mysqlnd 5.0.12

Steps to reproduce

  1. So please make any date filed
    dateRange Magento_Ui/js/grid/columns/date date date Date MMM dd, YYYY
  2. Open edited Grid,

Expected result

When make row inline editable an existing record, the date field should show the date from the record

Actual result

When make row inline editable an existing record, the date field show current date
1

@magento-engcom-team
Copy link
Contributor

Hi @Rutvee123. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@Rutvee123 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 13, 2018
@ghost ghost self-assigned this Aug 13, 2018
@ghost
Copy link

ghost commented Aug 13, 2018

@Rutvee123, thank you for your report.
We were not able to reproduce this issue by following the steps you provided. Please provide more detailed steps to reproduce or try to reproduce this issue on a clean installation or latest release.

@Rutvee123
Copy link
Author

Rutvee123 commented Aug 13, 2018

In Magento2.2.4 none any admin grid inline editable date filed exit .

So please make any date filed 👍
<column name="date" class="Magento\Ui\Component\Listing\Columns\Date"> <argument name="data" xsi:type="array"> <item name="config" xsi:type="array"> <item name="filter" xsi:type="string">dateRange</item> <item name="component" xsi:type="string">Magento_Ui/js/grid/columns/date</item> <item name="editor" xsi:type="string">date</item> <item name="dataType" xsi:type="string">date</item> <item name="label" xsi:type="string" translate="true">Date</item> <item name="dateFormat" xsi:type="string" translate="true">MMM dd, YYYY</item> </item> </argument> </column>

what i facing issue is given in below screen shot
please check
Grid display record with right date:
actual date
when inline edit date it display current date instead of actual date
currentdate issue

@Rutvee123
Copy link
Author

Have any update?

@ghost ghost removed the Progress: needs update label Aug 16, 2018
@ghost
Copy link

ghost commented Aug 16, 2018

@Rutvee123, thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Ui and removed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Aug 16, 2018
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 16, 2018
@ghost ghost added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 16, 2018
@ghost ghost removed their assignment Aug 16, 2018
@Rutvee123
Copy link
Author

Have any update?

@satyaprakashpatel satyaprakashpatel self-assigned this Feb 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @satyaprakashpatel. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@satyaprakashpatel
Copy link
Contributor

I am working on it #MM19IN

@magento-engcom-team
Copy link
Contributor

Hi @Rutvee123. Thank you for your report.
The issue has been fixed in #20902 by @satyaprakashpatel in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 14, 2019
magento-engcom-team added a commit that referenced this issue Feb 14, 2019
…grid with Ui Component #20902

 - Merge Pull Request #20902 from satyaprakashpatel/magento2:2.3-develop-inline-edit
 - Merged commits:
   1. e34db30
   2. 119fe1e
   3. 9b46c95
   4. 385aa60
magento-engcom-team pushed a commit that referenced this issue Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Ui Event: mm19in Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

3 participants