Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency symbol cannot be changed back to default value from admin panel in Single-store mode #17567

Closed
sivaschenko opened this issue Aug 13, 2018 · 11 comments
Closed

Currency symbol cannot be changed back to default value from admin panel in Single-store mode #17567

sivaschenko opened this issue Aug 13, 2018 · 11 comments
Assignees
@magently
Labels
Component: CurrencySymbol Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Aug 13, 2018 •
edited
Loading

Preconditions

Set "Enable Single-Store Mode" to Yes" in Stores -> Configuration -> General -> Single-Store Mode fieldset

Steps to reproduce

  1. Login to Admin Panel
  2. Go to Stores -> Currency Symbols
  3. Change any currency symbol value
  4. Save Currency Symbols
  5. Change currency symbol back to the default value (or check "Use Standard" checkbox)
  6. Save Currency Symbols

Expected result

Currency Symbol is set back to the default value

Actual result

A success message is shown, but currency symbol is not changed back to the default value
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@sivaschenko do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@sivaschenko sivaschenko changed the title Currency symbol cannot be changed back to default from admin panel Currency symbol cannot be changed back to default value from admin panel Aug 13, 2018
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Aug 13, 2018
@ghost ghost self-assigned this Aug 13, 2018
@ghost
Copy link

ghost commented Aug 13, 2018

@sivaschenko, thank you for your report.
You just need to flush cache.

@ghost ghost closed this as completed Aug 13, 2018
@sivaschenko
Copy link
Member Author

@engcom-backlog-pb there is no cache involved in the admin panel. The issue is still actual and should be reopened.

@mcspronko
Copy link
Contributor

@engcom-backlog-pb I wonder, who stands behind the answer about the cache.

@sivaschenko
Copy link
Member Author

Thank you! @miguelbalparda

@ghost
Copy link

ghost commented Aug 13, 2018

@sivaschenko, thank you for your report.
We were not able to reproduce this issue by following the steps you provided. Please provide more detailed steps to reproduce or try to reproduce this issue on a clean installation or latest release.
1

@sivaschenko sivaschenko changed the title Currency symbol cannot be changed back to default value from admin panel Currency symbol cannot be changed back to default value from admin panel in Single-store mode Aug 13, 2018
@sivaschenko
Copy link
Member Author

sivaschenko commented Aug 13, 2018 •
edited
Loading

@engcom-backlog-pb Sorry, I missed one important precondition: this is single-store mode issue. Title and description updated accordingly.

@sivaschenko
Copy link
Member Author

Here is a screen recording of what acvtually happens:
save-currency-symbol

@ghost
Copy link

ghost commented Aug 13, 2018

@sivaschenko, thank you for an update.
We've acknowledged the issue and added to our backlog.

@ghost ghost added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: CurrencySymbol and removed Progress: needs update labels Aug 13, 2018
@ghost ghost removed their assignment Aug 13, 2018
magently pushed a commit to magently/magento2 that referenced this issue Sep 7, 2018
Fix currency symbol setting back to default magento#17567
f1649dc
@magently magently mentioned this issue Sep 7, 2018
Merged
4 tasks
@ghost ghost assigned magently Sep 7, 2018
@sidolov sidolov added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Sep 22, 2018
@sidolov
Copy link
Contributor

sidolov commented Sep 22, 2018

Hi @sivaschenko. Thank you for your report.
The issue has been fixed in #17966 by @magently in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

@sidolov sidolov closed this as completed Sep 22, 2018
@mage2pratik mage2pratik mentioned this issue Sep 23, 2018
Merged
4 tasks
@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Oct 12, 2018
@sidolov
Copy link
Contributor

sidolov commented Oct 12, 2018

Hi @sivaschenko. Thank you for your report.
The issue has been fixed in #18204 by @mage2pratik in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

magento-engcom-team added a commit that referenced this issue Oct 12, 2018
@magento-engcom-team
ENGCOM-3037: [Forwardport] Fix currency symbol setting back to default …
c14aa54 
…#17567 #18204

 - Merge Pull Request #18204 from mage2pratik/magento2:2.3-develop-PR-port-17966
 - Merged commits:
   1. 4741320
magento-engcom-team pushed a commit that referenced this issue Oct 12, 2018
ENGCOM-3037: [Forwardport] Fix currency symbol setting back to default …
0e883ab 
…#17567 #18204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magently magently

Labels
Component: CurrencySymbol Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sivaschenko @mcspronko @miguelbalparda @magently @sidolov @magento-engcom-team