Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Customizable Options Value, can't save SKU value #18037

Closed
SvanteAvenla opened this issue Sep 13, 2018 · 15 comments
Closed

Product Customizable Options Value, can't save SKU value #18037

SvanteAvenla opened this issue Sep 13, 2018 · 15 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@SvanteAvenla
Copy link

Preconditions

  1. Magento CE 2.2.3
  2. PHP 7.0.30

Steps to reproduce

  1. Create a new Simple product.
  2. Add a new Customizable Option ('Option Title' => 'Radio', 'Option Type' => 'Select - Radio Buttons').
  3. Add two Option Values with these values:
    ['title' => 'One', 'Price' => '10', 'Price Type' => 'Fixed', 'SKU' => 'Performance problem & memory leak in Mage_Index_Model_Process #123'],
    ['title' => 'Two', 'Price' => '20', 'Price Type' => 'Fixed', 'SKU' => 'Bogus error message if mcrypt extension is not installed. #456']
  4. Fill the rest of the required information to be able to save the new product.
  5. Save the product.
  6. Edit the products Customizable Option, change the Option Values to these values (SKU's are the same):
    ['title' => 'One', 'Price' => '10', 'Price Type' => 'Fixed', 'SKU' => 'Performance problem & memory leak in Mage_Index_Model_Process #123'],
    ['title' => 'Two', 'Price' => '20', 'Price Type' => 'Fixed', 'SKU' => 'Performance problem & memory leak in Mage_Index_Model_Process #123']
  7. Save the product.

Expected result

  1. The product should contain a Customizable Option with two Option Values, both with SKU set to 'Performance problem & memory leak in Mage_Index_Model_Process #123'.

Actual result

  1. The product contains a Customizable Option with two Option Values, the first with SKU set to 'Performance problem & memory leak in Mage_Index_Model_Process #123' and the second with SKU set to 'Bogus error message if mcrypt extension is not installed. #456'.

Additional notes

The SKU value is unset in the function Magento\Framework\Model\ResourceModel\Db->prepareDataForUpdate($object).

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @SvanteAvenla. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@SvanteAvenla do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@SvanteAvenla
Copy link
Author

@magento-engcom-team give me 2.2.3 instance

@magento-engcom-team
Copy link
Contributor

Hi @SvanteAvenla. Thank you for your request. I'm working on Magento 2.2.3 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @SvanteAvenla, here is your Magento instance.
Admin access: https://i-18037-2-2-3.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost self-assigned this Sep 13, 2018
@ghost ghost added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 13, 2018
@SvanteAvenla
Copy link
Author

I was able to reproduce the issues on the vanilla Magento instance you provided me with.

@ghost ghost added Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Sep 13, 2018
@ghost
Copy link

ghost commented Sep 13, 2018

Hi @SvanteAvenla The fix for this issue has already available in 2.2-develop branch.

@ghost ghost closed this as completed Sep 13, 2018
@ghost ghost added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 13, 2018
@ghost
Copy link

ghost commented Sep 13, 2018

selection_085

@SvanteAvenla
Copy link
Author

SvanteAvenla commented Sep 13, 2018

Where is the commit fixing this issue? I would like to see how the fix is done?

@ghost
Copy link

ghost commented Sep 13, 2018

@SvanteAvenla i'm can't find commit or PR , but i'm tested it on 2.2-develop branch and have no issue any more.

@SvanteAvenla
Copy link
Author

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @SvanteAvenla. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @SvanteAvenla, here is your Magento instance.
Admin access: https://i-18037-2-2-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@SvanteAvenla
Copy link
Author

SvanteAvenla commented Sep 13, 2018

Seems you are right. I can't reproduce the issue in the 2.2-develop either. If you find the commit and remember me please post the commit id here. I'm curious.

Thank you for your time!

@ghost
Copy link

ghost commented Sep 13, 2018

@SvanteAvenla ok.

@Ctucker9233
Copy link

@engcom-backlog-nazar I'm interested in seeing the commit as well or at least what version of Magento it's slated for.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

3 participants