Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CacheInvalidate : stop at first server not responding #18056

Closed
benjamin-volle opened this issue Sep 14, 2018 · 4 comments
Closed

CacheInvalidate : stop at first server not responding #18056

benjamin-volle opened this issue Sep 14, 2018 · 4 comments
Labels
Component: PageCache Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@benjamin-volle
Copy link

Preconditions

All Magento versions

Steps to reproduce

  1. Setup 2 Varnish servers (cache1 and cache2) in the http_cache_hosts section of "env.php"
  2. Turn off the first one (cache1)
  3. Try to flush the full_page by launching bin/magento cache:flush full_page

Expected result

The full_page is flushed for cache2 (the only one responding)

Actual result

The full_page is not flushed for all servers

The problem is located here :
\Magento\CacheInvalidate\Model\PurgeCache::sendPurgeRequest

In the "foreach" loop, there is a "return false" at the first exception insteag of "continue", preventing the try on all servers.

@magento-engcom-team
Copy link
Contributor

Hi @synolia-bvo. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@synolia-bvo do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 14, 2018
@ghost ghost self-assigned this Sep 14, 2018
@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: PageCache Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Sep 14, 2018
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-95006, MAGETWO-95007 were created

@ghost
Copy link

ghost commented Sep 14, 2018

Hi @synolia-bvo , thank you for your report.
We've acknowledge the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PageCache Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

2 participants