Changes cache hosts warning / critical levels and continue on multiple hosts

[wiardvanrij]

Description (*)

When purging varnish hosts it could be possible 1 or more hosts are unresponsive.
Two changes here:

1. It should continue to purge other hosts even though 1 of the X servers is offline/unavailable.
2. Provide a warning if more hosts are available and a critical if that was the only host

Fixed Issues (if relevant)

1. CacheInvalidate : stop at first server not responding #18056: CacheInvalidate : stop at first server not responding
2. ...

Manual testing scenarios (*)

1. Have multiple cache hosts
2. bin/magento cache:flush full_page

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @wiardvanrij. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sivaschenko]

Please see my propositions on the possible contribution improvement

[sivaschenko]

Hi @wiardvanrij thank you for this useful contribution. I have an improvement proposition for this PR, that I described in the review comments. Please let me know what you think!

[sivaschenko]

Thanks for the refactoring, please see the remaining comment about a couple of minor changes required

[sivaschenko]

Few final cosmetic changes required

[sivaschenko]

Each parameter should be in line by itself in multiline function call, example:

$this->logger->critical(
    'No cache server(s) could be purged ' . $loggerMessage,
    compact('server', 'formattedTagsChunk')
);

[wiardvanrij]

Sorry I think I misunderstood you :) It is changed now

[ghost]

Hi @wiardvanrij, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.