Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itemPrice blocks in Wishlist obsolete? #184

Closed
amenk opened this issue Jan 4, 2013 · 1 comment
Closed

itemPrice blocks in Wishlist obsolete? #184

amenk opened this issue Jan 4, 2013 · 1 comment

Comments

@amenk
Copy link
Contributor

amenk commented Jan 4, 2013

Since Magento 1.6, it looks like _getItemPriceBlock in the wishlist seems to be no longer in use.

https://github.com/magento/magento2/blob/master/app/code/core/Mage/Wishlist/Block/Abstract.php#L330

So in fact, the default block which is defined in the constructor is also not applied:

https://github.com/magento/magento2/blob/master/app/code/core/Mage/Wishlist/Block/Abstract.php#L72

Can we remove the whole item price block functionality in the wishlist module? Or am I missing some point?
magento-team added a commit that referenced this issue Dec 27, 2013
@magento-team
2.0.0.0-dev58
6d9aa05 
* Fixed bugs:
  * Security improved for the Login, Update Cart, Add to Compare, Review, and Add entire wishlist actions on the frontend
  * Removed warnings on category pages when Flat Catalog Category is enabled
  * Fixed product price displayed in wrong currency after switching currency on the frontend
  * Fixed the Save & Duplicate action in product creation
  * Fixed big image scaling in product description
  * Fixed admin dashboard styling issue
  * Fixed validation message for the Quantity field on the product page in the backend
  * Fixed the email template for sharing a Wishlist
  * Fixed the response of the drop-down menu in the Plushe theme
  * Fixed the missing Related Banners tab for Catalog Price Rule
  * Fixed inability to enable the duplicated product
  * Removed warnings on saving payment method configuration
  * Fixed gift messages displaying on the Order View page after admin edits
  * Fixed inability to create a new order status
  * Fixed the behavior of the Save and Previous and the Previous buttons on the Edit Review page
  * Fixed inability to delete a website if the number of websites is less or equal to two
  * Fixed Export on the All Customers page
  * Fixed inability to add products to the Shopping Cart from the Category page in Internet Explorer
  * Fixed logo on the backend login page
  * Fixed visual elements to indicate that Tax details can be expanded on the order creation page in the backend
  * Fixed the CMS page preview design
  * Fixed the newsletter template preview design
  * Fixed the Matched Customers grid design in the Email Reminder Rules
  * Fixed the theme version validation message displayed when creating a new theme
  * Fixed performance degradation during installation wizard execution
  * Fixed cron shell script
  * Fixed user login on the frontend, when the Redirect Customer to Account Dashboard after Logging option is set to No
  * Fixed errors in requests to shipping carrier (DHL International) when the shipping address contains letters with diacritic marks
  * Fixed invalid account creation date
  * Fixed displaying Product Alert links on product view page when the functionality is disabled
  * Fixed the absence of some bundle options when configuring a bundle product in the Shopping Cart on the frontend
  * Fixed the issue which allowed to view and cancel billing agreements belonging to another customer
  * Fixed the content spoofing vulnerability when Solr was used
  * Fixed a potential XSS vulnerability in customer login
  * Fixed RSS feed for categories containing bundle product(s)
  * Fixed inability to place an order with 3D Secure in Internet Explorer 10
  * Fixed inability to place an order with PayPal Payflow Link and PayPal Payments Advanced
  * Fixed integrity constraint violation in catalog URL rewrites
  * Fixed the absence of the error when a wrong website code is specified during a website creation
  * Fixed saving in the backend a new customer address, which contains new customer address attributes configured to be not visible on frontend
  * Fixed USPS shipping method in the checkout
  * Fixed placing orders with recurring profile items via PayPal Express Checkout
  * Fixed email template creation in the backend
  * Fixed the issue with default billing address being used instead of default shipping address during admin order creation
  * Fixed inability to choose DB as Media Storage
  * Fixed PHP issues found during the UI testing of the backend
  * Fixed shipping label creation for USPS Priority Mail Shipping methods
  * Fixed the issue which allowed to create customers with duplicate email
  * Fixed the abstract product block error in the tier price template getter
  * Fixed system message displaying in the backend
  * Fixed the "404" error on customer review page
  * Fixed autocomplete enabled on the admin login page
  * Fixed the 3D Secure iframe
  * Fixed the indicators of mandatory fields on the Package Extension page
  * Fixed product image scaling on the Compare Products page
  * Fixed product page design for products with the Fixed Product Tax attribute
  * Removed spaces between parentheses and numbers in the Cart, Wishlist, and Compare Products blocks
  * Fixed the message displaying the quantity for products found on the Advanced Search page
  * Fixed incorrect caching of locale settings and URL settings during web installation
  * Fixed inability to use a newly created store for admin user roles
  * Fixed absence of the Advanced Search field on the frontend, when the Popular Search Terms functionality is disabled
  * Fixed incorrect link to downloadable product(s) in the email invoice copy
  * Fixed customs monetary value in labels/package info for international shipments
  * Fixed importing for files with blank URL Key field on the store view level
  * Fixed table rate error message
  * Fixed frontend login without pre-set cookies
  * Fixed date resetting to 1 Jan 1970 after saving a design change in the admin panel in case date format is DD/MM/YY
  * Fixed CAPTCHA on multi-address checkout flow
  * Fixed view files population tool
* GitHub requests:
  * [#122](#122) -- Added support of federal units of Brazil with 27 states
  * [#184](#184) -- Removed unused blocks and methods in Magento_Wishlist module
  * [#390](#390) -- Support of alphanumeric order increment ids by the quote resource model
* Themes update:
  * Responsive design improvements
* Improvements in code coverage calculation:
  * Code coverage calculation approach for unit tests was changed from blacklist to whitelist
@verklov
Copy link
Contributor

verklov commented Dec 27, 2013

@amenk , we have fixed the issue that you reported. The fix is available in version dev58.

@verklov verklov closed this as completed Dec 27, 2013
vpelipenko added a commit that referenced this issue Mar 23, 2015
@vpelipenko
Merge pull request #184 from magento-mpi/publication
8b8cd0b 
[Publication] M2 GitHub Update (version 0.74.0-beta1)
maksek pushed a commit that referenced this issue Nov 17, 2015
Merge pull request #184 from magento-goinc/MAGETWO-45453
5923c2b 
[GoInc] BugsFixing
mmansoor-magento pushed a commit that referenced this issue Aug 1, 2016
Merge pull request #184 from magento-frontend/MAGETWO-55217-new
2d0d716 
[Frontend] Process Public Pull Requests
magento-engcom-team added a commit that referenced this issue Sep 16, 2018
@magento-engcom-team
ENGCOM-1391: [2.3-develop] Forwardport of #11323 #184
3aa0cb2 
 - Merge Pull Request magento-engcom-team/magento2ce#184 from magento-engcom-team/magento2ce:forwardport-2.3-develop-magento-magento2-11323
 - Merged commits:
   1. bcd05dd
   2. e8ad131
magento-engcom-team pushed a commit that referenced this issue Sep 16, 2018
ENGCOM-1391: [2.3-develop] Forwardport of #11323 #184
929378f
magento-engcom-team added a commit that referenced this issue Sep 18, 2018
@magento-engcom-team
ENGCOM-2989: Recheck 129 retrive customer token #184
3f8dfd8 
 - Merge Pull Request magento/graphql-ce#184 from magento/graphql-ce:recheck-129-retrive-customer-token
 - Merged commits:
   1. 527e4fe
   2. ea9b2a8
   3. ca0c135
   4. c0d1b7b
   5. e97301d
   6. 85cd239
   7. 6a250c1
   8. 21e719c
   9. ad388f6
   10. 277fe08
   11. 5dce3bd
magento-engcom-team pushed a commit that referenced this issue Sep 18, 2018
ENGCOM-2989: Recheck 129 retrive customer token #184
30b908e
PierreLeMaguer added a commit to PierreLeMaguer/magento2 that referenced this issue Sep 11, 2019
@PierreLeMaguer
[Children Ids] magento#184 - Create a cache to store children ids
f55e1fd
magento-cicd2 pushed a commit that referenced this issue Jan 28, 2020
@RyanZolper
Merge pull request #184 from magento-pangolin/MC-9023
3effd32 
MC-9023 Backport for MC-13245
magento-devops-reposync-svc pushed a commit that referenced this issue Dec 15, 2023
@sumesh-GL @svera
Merge pull request #184 from sumesh-GL/LYNX-303
b74802f 
LYNX-303: Added `max_items_in_order_summary` in storeConfig graphql query.
Merging as PR is approved and all tests are green
magento-devops-reposync-svc pushed a commit that referenced this issue Jan 4, 2024
@sumesh-GL
Merge pull request #184 from sumesh-GL/LYNX-303
80a353c 
LYNX-303: Added `max_items_in_order_summary` in storeConfig graphql query.
Merging as PR is approved and all tests are green
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amenk @verklov